Fix for issue #26 to preserve overflowing containers' scroll position

bigskysoftware / idiomorph

A DOM-merging algorithm

BSD 2-Clause "Simplified" License

693 stars 33 forks source link

Fix for issue #26 to preserve overflowing containers' scroll position #42

Closed KDreynolds closed 3 months ago

KDreynolds commented 7 months ago

I took a stab at addressing the issue user @adicco mentions in issue #26, preserving scroll position in overflowing containers.

KDreynolds commented 6 months ago

We are so back

AlexanderArvidsson commented 6 months ago

Personally, I would probably not do this as a top-level operation, and instead as a beforeNodeMorphed and afterNodeMorphed callback. I think this can actually be implemented completely through the callbacks without modification to the source. Not saying it shouldn't be fixed, but the approach should probably be different.