Closed davidalejandroaguilar closed 1 year ago
Hi david,
Looks good, would you mind adding some tests for the change?
@1cg My bad, didn't notice we had a tests folder, I'll add them.
hey @davidalejandroaguilar just checking in on this, would like to merge w/ some tests
Looking forward to this being merged - in my case, idiomorph is trying to merge <svg>
child elements where I just want the entire new <svg>
to overwrite the old.
OK, merging w/o tests. I will add some later. (lol)
This looks fantastic! @1cg Any chance this could be released? As far as I can tell, the current release on npm doesn't include the changes from this PR.
i will try to cut a release tomorrow
🤠
should be available in the latest release on NPM
I just noticed I abandoned this PR 🤦🏼♂️ . My apologies @1cg, life got in the way but absolutely didn't mean to ghost you.
Thank you for merging!
This adds the possibility of stopping a behavior from a callback if it returns
false
, as it's done on morphdom.