FontAwesome dependencies not deployed as bower_components is ignored

bigspring / monolith

A starter theme for WordPress built with Twitter Bootstrap

MIT License

9 stars 1 forks source link

FontAwesome dependencies not deployed as bower_components is ignored #297

Closed dmseaton closed 9 years ago

dmseaton commented 9 years ago

I propose that we resolve this by:

override the FontAwesome relative path in an appropriate SCSS file if possible
extend Grunt to copy required files to site assets

In order to maintain best practices for dependencies we should keep bower_components in .gitignore

juliotaylor commented 9 years ago

temporarily removed bower_components from ignore file until this is fixed in a better way

dmseaton commented 9 years ago

Just FYI, I successfully implemented a fix for this in Just Landlords - it's just an amendment to the FA path in compiler.scss, and Grunt copies the FA font files to populate the new path. Will need some examples of fairheadwebicons in use so I can do similar with that (assuming they're still going to be used).

juliotaylor commented 9 years ago

that's fine, happy for you to fix permantently on dev

On Mon, Mar 23, 2015 at 4:21 PM dmseaton notifications@github.com wrote:

Just FYI, I successfully implemented a fix for this in Just Landlords - it's just an amendment to the FA path in compiler.scss, and Grunt copies the FA font files to populate the new path. Will need some examples of fairheadwebicons in use so I can do similar with that (assuming they're still going to be used).

— Reply to this email directly or view it on GitHub https://github.com/bigspring/monolith/issues/297#issuecomment-85073870.

dmseaton commented 9 years ago

Fixed, needs review for Fairweather stuff but fa appears to work