bigspring / monolith

A starter theme for WordPress built with Twitter Bootstrap
MIT License
9 stars 1 forks source link

Review logic for how sidebars are included #347

Open juliotaylor opened 8 years ago

juliotaylor commented 8 years ago
juliotaylor commented 8 years ago

@dmseaton did you come up with some logic / magic for deciding where sidebars / full width is used?

juliotaylor commented 8 years ago

The way sidebars are used / shown needs a wider review. Something clever is needed.

dmseaton commented 8 years ago

If we're talking about the same thing, I just split the start/end row into partials to be included where needed. Maybe these parts could be included in the header by default, but be easy to comment out and use elsewhere (a bit like _getheader()/_getfooter()).

juliotaylor commented 8 years ago

will these partials include the logic for the column split?

we'll need one for full width pages too I assume?

is there a way to achieve this with an equivalent to build()?

juliotaylor commented 8 years ago

I propose we remove sidebars from the footer, and add them to the specific template as and when it's needed. So, each template has its own structural markup, and sidebar is included as a organism as and when it's needed.

Thoughts? @dmseaton @jrgmartin

juliotaylor commented 8 years ago

possibly something for 2.1