Improve error handling with pages shortcode

bigspring / monolith

A starter theme for WordPress built with Twitter Bootstrap

MIT License

9 stars 1 forks source link

Improve error handling with pages shortcode #370

Open harrybigspring opened 8 years ago

harrybigspring commented 8 years ago

When using the pages shortcode, if you don't provide page IDs then you will get a PHP error. The shortcode needs to handle cases where there is no page ids.

juliotaylor commented 8 years ago

I propose that in production mode, it does not display an error at all to save it looking shit on live sites. On dev mode we can display an elegnt error.

jrgmartin commented 8 years ago

Agreed!

juliotaylor commented 8 years ago

@jrgmartin what's the plan here?

jrgmartin commented 8 years ago

It's relatively simple to build in some logic based around the the production and dev mode.

juliotaylor commented 8 years ago

is this something we need to move over to M3?