Closed minkimcello closed 4 years ago
The preview action is failing because package is marked private. Can't make it not-private it seems because yarn workspace requires it to be private?
I know we added a feature in the preview action in resideo/actions
to skip private packages but I'll have a look to see how their monorepo is different and why it allows them to have public packages.
The preview packages of this pull request have been published. Click on the following packages for instructions on how to install them:
Generated by :no_entry_sign: dangerJS against 659c632519c5174b06131aa06894c0019ff02974
BigTest's new code is being written in Typescript, should we evaluate whether we should do so on this website too?
I noticed that you're using CSS vars in the code. However, we want to avoid having any global CSS. Instead, we want explicit dependencies. For this reason, we should use variables from a theme. This will also allow us to change themes programatically (ie. for dark theme).
You can read more about Themes in styled-components here: https://styled-components.com/docs/advanced#theming
@taras Does Bigtest org have its own Netlify account? Can we point its site to this repository to see if it deploys preview properly?
@minkimcello we might want to move this to Frontside before we setup netlify. It gets confusing.
@minkimcello we might want to move this to Frontside before we setup netlify. It gets confusing.
Yes, let's do that.
@jorgelainfiesta Should I get a 👍 before merge?
Motivation
We're creating a new website for
bigtest
. I created the landing page on my own repository and it's now being moved here hence the sizable pull request.Approach
The website was constructed using
gatsby
,netlify
, andstyled-components
.packages/website
as ignore argument to publish preview workflow.Future TODOs
packages/website/todos/notes.md
Learning