bigtestjs / server

All BigTest development has moved to https://github.com/thefrontside/bigtest
https://github.com/thefrontside/bigtest
2 stars 1 forks source link

Upgrade `ts-node` dependency #47

Closed chuckcarpenter closed 4 years ago

chuckcarpenter commented 4 years ago

ts-node was not a dependency or a noted required global. I prefer local dependencies, but doing that required path updates to the bin in the processes to run the server.

pittst3r commented 4 years ago

I thought that when run via yarn or npm, node_modules/.bin was appended to $PATH?

I thought this too, except I thought that it prepended so that it looked in the local node modules first.

cowboyd commented 4 years ago

@pittst3r ah yes, that’s right.

chuckcarpenter commented 4 years ago
[chuckcarpenter:~/Projects/bigtest:server]$ yarn start
yarn run v1.19.1
$ ts-node -r module-alias/register bin/start.ts
/bin/sh: ts-node: command not found
error Command failed with exit code 127.

@cowboyd didn't work that way for me

chuckcarpenter commented 4 years ago

@pittst3r I've cleaned it up

chuckcarpenter commented 4 years ago

@pittst3r looks like I can't merge

cowboyd commented 4 years ago

ts-node was not a dependency or a noted required global. I prefer local dependencies, but

Is this true? Looks like the PR just bumps up the existing dependency (also fine, but we should update the description)

cowboyd commented 4 years ago

@pittst3r @chuckcarpenter what are we doing with this one?

pittst3r commented 4 years ago

I don't know why the build is not running and don't feel comfortable merging with a pending build.

chuckcarpenter commented 4 years ago

@cowboyd this is all fine for me now.