search

bigtreetech / BIGTREETECH-TouchScreenFirmware

support TFT35 V1.0/V1.1/V1.2/V2.0/V3.0, TFT28, TFT24 V1.1, TFT43, TFT50, TFT70
GNU General Public License v3.0
1.31k stars 1.65k forks source link

Cleanner history with rebase #10

Closed robbycandra closed 4 years ago

robbycandra commented 5 years ago

Dear @bigtreetech , it is cleaner if PR not merged but rebased.

thisiskeithb commented 5 years ago

Yes, please!

robbycandra commented 5 years ago

Hello @thisiskeithb , nice to meet you here.

thisiskeithb commented 5 years ago

You too! My TFT24 finally cleared customs, so now I'm busy putting in PRs :)

robbycandra commented 5 years ago

I am still slow. Wait and see where the wind blow. Now, I just fix things here and there.

robbycandra commented 5 years ago

@thisiskeithb , for me, its like a split version of MKS Robin TFT. We need a big map on how this UI will talk with Marlin. Do you have any idea about it ?

thisiskeithb commented 5 years ago

The TFT side is just like the MKS TFTs since it's basically a standalone controller that sends gcodes back to Marlin.

For the 12864 emulation, it's just like the standard REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER/uses the standard Marlin UI.

robbycandra commented 5 years ago

I make this Screen as Extensible UI. I love it because it has Encoder Button. Maybe i will rebuild the firmware.

thisiskeithb commented 5 years ago

I'd be curious to see it! Have a link? :)

robbycandra commented 5 years ago

It still in very early development. First thing I do is make a status screen like UltraLCD.

BTW. we can also use code from here to build the "missing" MKS Robin TFT code

robbycandra commented 5 years ago

image this is what happened to my screen.

thisiskeithb commented 5 years ago

this is what happened to my screen.

It's fine if you ignore the GUI side. 🙂But really, this probably won't change.

vMeph commented 5 years ago

sorry to jump in @robbycandra and @thisiskeithb but it seems this is the only active issue lol was wondering if this TFT 35 at some point will have some basic display like the reprap lcd like first screen show x y z position temp of bed and hotend fan and then yes go into menus thats what seems to make sense in this LCD to have at this point it seems that the TFT firmware is missing alot stuff, i wanted to move my machine to have this LCD but im waiting to see if the firmware becomes a litle more useful

robbycandra commented 5 years ago

@vMeph , Marlin firmware already have something called Extensible UI that will take care communication between User Interface and Marlin. But it still need more work And The work must be done in LCD firmware and Marlin Firmware.

guruathwal commented 4 years ago

@robbycandra Should this be closed now ?

robbycandra commented 4 years ago

Yes Close

guruathwal commented 4 years ago

Then please close it.

github-actions[bot] commented 6 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.