bigtreetech / BIGTREETECH-TouchScreenFirmware

support TFT35 V1.0/V1.1/V1.2/V2.0/V3.0, TFT28, TFT24 V1.1, TFT43, TFT50, TFT70
GNU General Public License v3.0
1.3k stars 1.65k forks source link

Bug when printing from Marlin mode. #1058

Closed Neme77 closed 3 years ago

Neme77 commented 4 years ago

Description

When a print is launched from the Marlin mode, the display changes and automatically activates the TFT mode

Steps to reproduce

  1. [Update to latest release]
  2. [launch print from Marlin mode]

Hardware Variant

TFT35 V3

TFT Firmware Version & Main Board Firmware details

Latest Firmware for TFT35 V3 with SKR 1.4 Marlin Bugfix 2.0.6.1

Additional Information

blueeagle69 commented 4 years ago

I'm running the TFT35 E3 V3 on my Biqu B1 (latest FW) and I can't reproduce this.

zonalimitatore commented 4 years ago

The same to me. Last firmware avaiable. tft24,if im in marlin and do a print from sd,automatically switch to touch mode

Manu512 commented 4 years ago

Hello,

Same with Last Firmware. And Filament Sensor doesnt work for me. I've a sensor on the SKR1.4 Turbo and another on the TFT and no one work correctly.

I've Two extruders on a mixing hotend.

charakaSamawry commented 4 years ago

If youve made any changes in the config.ini the issue could be a change youve made, so you should upload those files somewhere and post the link here so ppl can see what might be wrong. I think the best way is to use github desktop and push your changes to a your own branch on a BTT TSF fork so anyone can go check out your fork and you can easily link to your changes/config files easily without having to uplaod/zip them or pastebin them

Neme77 commented 4 years ago

If youve made any changes in the config.ini the issue could be a change youve made, so you should upload those files somewhere and post the link here so ppl can see what might be wrong. I think the best way is to use github desktop and push your changes to a your own branch on a BTT TSF fork so anyone can go check out your fork and you can easily link to your changes/config files easily without having to uplaod/zip them or pastebin them

I compile myself the firmware with PlatformIO. This is my Configuration.H

Configuration.zip

zonalimitatore commented 4 years ago

Isn't a config problem....My problem start with upgrade of the official firmware

LongLiveCHIEF commented 4 years ago

Could you post just the file, and not a zip? Put it in a gist or link to your fork.

charakaSamawry commented 4 years ago

People have no easy way of knowing what changes you made and when you last updated everything. (ie which changes happened in between your last update and this most recent one that introduced these problems). Configuration file is good but hard to see what changes you made with out being more familiar with the code

It would be useful to have your folder of the BTT TSF uploaded to a personal branch on a fork of BTT TSF on your github so people can see all your files and the exact changes that you made, since youre compiling it yourself there's more that can go wrong.

Easiest way is to fork BTT/BTT TSF and create a new branch with your changes copied into it (In github desktop) then push it so its public, here online, for others to view.

Using github desktop makes life easy and works with VSCode plugins really nicely as well. Which people could use to more easily identify your problem, if your folder was public, on personal branch with your changes. You can open easy to read comparisons with previous version ,PRs or Issues or specific commits even. I could even compare youre config to mine and it highlights the differences. (Uses the feature to quickly fix clashes as well during a merge. opens vscode from github desktop and highlights clashes with options to include the old or new changes or even edit manually the changes) sorry if you knew that

Neme77 commented 4 years ago

People have no easy way of knowing what changes you made and when you last updated everything. (ie which changes happened in between your last update and this most recent one that introduced these problems). Configuration file is good but hard to see what changes you made with out being more familiar with the code

It would be useful to have your folder of the BTT TSF uploaded to a personal branch on a fork of BTT TSF on your github so people can see all your files and the exact changes that you made, since youre compiling it yourself there's more that can go wrong.

Easiest way is to fork BTT/BTT TSF and create a new branch with your changes copied into it (In github desktop) then push it so its public, here online, for others to view.

Using github desktop makes life easy and works with VSCode plugins really nicely as well. Which people could use to more easily identify your problem, if your folder was public, on personal branch with your changes. You can open easy to read comparisons with previous version ,PRs or Issues or specific commits even. I could even compare youre config to mine and it highlights the differences. (Uses the feature to quickly fix clashes as well during a merge. opens vscode from github desktop and highlights clashes with options to include the old or new changes or even edit manually the changes) sorry if you knew that

Thanks for your reply and interest, I will soon publish a fork on github. I would like to clarify that I also tried with the pre-compiled firmware for tft35 v3 and the problem persists.

charakaSamawry commented 4 years ago

The devs should be able to help. I’ll have to try it on my printer now.. always print from touch screen so haven’t noticed this issue myself.

Do you use the most up to date files? or releases? Have you tried using the latter? Ie master vs release xx.26.1

Neme77 commented 4 years ago

The devs should be able to help. I’ll have to try it on my printer now.. always print from touch screen so haven’t noticed this issue myself.

Do you use the most up to date files? or releases? Have you tried using the latter? Ie master vs release xx.26.1

Yes, i use the latest Master....

oldman4U commented 4 years ago

@charakaSamawry

I believe it would be great if you could make a documentation how sharing configurations works best. Most users have troubles to compile their own firmware, so having a guide which describes what to do and what finally can be done with such a setup, would be great!

THANK YOU

Neme77 commented 4 years ago

@charakaSamawry

I believe it would be great if you could make a documentation how sharing configurations works best. Most users have troubles to compile their own firmware, so having a guide which describes what to do and what finally can be done with such a setup, would be great!

THANK YOU

https://github.com/Neme77/BIGTREETECH-TouchScreenFirmware

oldman4U commented 4 years ago

@Neme77

Thank you. I know this, but it is scratching on the surface compared to what @charakaSamawry described.

traffic-light commented 4 years ago

@oldman4U I can add it in the pinned message and manual

oldman4U commented 4 years ago

Good morning my green, yellow and red friend.

I believe this has to be added to the mainpage or the existing manual of the firmware page. But if you know this all it would be great to add it with some screenshots.

It would be useful to have your folder of the BTT TSF uploaded to a personal branch on a fork of BTT TSF on your github so people can see all your files and the exact changes that you made, since youre compiling it yourself there's more that can go wrong.

Easiest way is to fork BTT/BTT TSF and create a new branch with your changes copied into it (In github desktop) then push it so its public, here online, for others to view.

Using github desktop makes life easy and works with VSCode plugins really nicely as well. Which people could use to more easily identify your problem, if your folder was public, on personal branch with your changes. You can open easy to read comparisons with previous version ,PRs or Issues or specific commits even. I could even compare youre config to mine and it highlights the differences. (Uses the feature to quickly fix clashes as well during a merge. opens vscode from github desktop and highlights clashes with options to include the old or new changes or even edit manually the changes) sorry if you knew that

traffic-light commented 4 years ago

Never used GitHub desktop. For so far I see it's not compatible with linux...

I'll have to take a look at it.

oldman4U commented 4 years ago

Charaka seems to know this. So it would be great if (s)he can help with this.

charakaSamawry commented 4 years ago

https://github.com/desktop/desktop/issues/1525 https://github.com/shiftkey/desktop Glad I could help. I’ve just got good google-fu btw not actually versed in this stuff. JustGoogled it to find those links for you for instance. Done more researching than printing to be honest lol

oldman4U commented 4 years ago

👍🏻

Thank you

traffic-light commented 4 years ago

Yeah. I already noticed that arch linux's aur repository contains GitHub desktop ;-)

zonalimitatore commented 4 years ago

So,no news about this bug?

Neme77 commented 4 years ago

So,no news about this bug?

Ciao una curiosità hai per caso Marlin 2.0.6.1???

zonalimitatore commented 4 years ago

So,no news about this bug?

Ciao una curiosità hai per caso Marlin 2.0.6.1???

Mmmm...2.0.6 sicuro.. l'1 bhoooo

zonalimitatore commented 4 years ago

Maybe ive solved.... I delete initial gcode,pause gcode,end gcode(touch mode side). I've try to load a file on sd card from marlin mode,and it work

blueeagle69 commented 4 years ago

I just did a fresh build from the latest source. And now oddly I have the same issue! The only thing I changed in source was in Selectmode.c Changing 12864 Mode text to Marlin mode (which I have always done).

I start a print in Marlin mode and the screen instantly switches to TFT mode. Also the buttons such as Stop become unresponsive.

blueeagle69 commented 4 years ago

Well another weird one. Sure enough if I started a print in Marlin mode, it would switch immediately to TFT mode, and the Stop button wasn't responding. So I flashed the firmware version from the Biqu B1 repo and the issue went away. I then re-flashed the latest build from this repo, and no more mode-switching when starting a print. Strange. But hey it appears to be working.

zonalimitatore commented 4 years ago

Very interesting....Seems a eeprom problem

blueeagle69 commented 4 years ago

It started doing it again. This is driving me insane. Flashed the Biqu B1 FW again for the TFT. And again, problem solved.

oldman4U commented 4 years ago

@blueeagle69 Are you using precompiled or selfcompiled firmware for the TFT?

blueeagle69 commented 4 years ago

Self compiled. The only code I change is in Selectmode.c Changing "12864 mode" to "Marlin mode"

charakaSamawry commented 4 years ago

Strange but you might want to try with the same amount of characters in your change. I had a weird issue with I forget the exact details of what issue it caused tbh. But I changed the displayed text at the top of the lcd12864 in config.ini and had to change out to the same amount of characters to fix ‘something’ I can’t remember. My commit where I tried using the same account if characters after a previous change with more characters than ‘12864 Mode’ https://github.com/charakaSamawry/BIGTREETECH-TouchScreenFirmware/commit/b81ebdcda5356d0be546cf90236c737fea0e71fc

oldman4U commented 4 years ago

I asked because we saw some strange issues with the precompiled version.

zonalimitatore commented 4 years ago

Question for all. In configuration_adv.h how have SD? Not defined, onboard, LCD, Custom?

blueeagle69 commented 4 years ago

Strange but you might want to try with the same amount of characters in your change. I had a weird issue with I forget the exact details of what issue it caused tbh. But I changed the displayed text at the top of the lcd12864 in config.ini and had to change out to the same amount of characters to fix ‘something’ I can’t remember. My commit where I tried using the same account if characters after a previous change with more characters than ‘12864 Mode’ charakaSamawry@b81ebdc

It is weird. It was working perfect for ages, but started happening all of a sudden. I'm still on the B1 compiled FW. Will have to flash again from the latest source and see if it behaves, leaving Selectmode.c unchanged and see what that does, despite the text "12864 mode" triggering me when I change modes 😉

blueeagle69 commented 4 years ago

Question for all. In configuration_adv.h how have SD? Not defined, onboard, LCD, Custom?

This should be posted in a separate question, or better still on the Marlin page. The maintainers would understandably want to keep things neat and relevant. But in case it matters, My Marlin fw is set on ONBOARD.

zonalimitatore commented 4 years ago

If I asked here it's because can be for that

zonalimitatore commented 4 years ago

If I asked here it's because can be for that

zonalimitatore commented 4 years ago

So...one tell me that have define LCD on board Others?

blueeagle69 commented 4 years ago

I asked because we saw some strange issues with the precompiled version. I just flashed the pre-compiled latest FW, fonts, config etc. Started a print from Marlin mode and sure-enough the display immediately switched to TFT and again the Stop button was un-responsive. But Pause etc worked. I then re-flashed the Biqu B1 TFT FW (I have the Biqu B1). Yet again, problem solved with the older firmware, I believe the Biqu B1 uses a custom Bigtreetech TFT35 E3 V3.

Hope this helps.

oldman4U commented 4 years ago

@blueeagle69

So you also believe this could be related to the pre-compiled version?

blueeagle69 commented 4 years ago

@blueeagle69

So you also believe this could be related to the pre-compiled version?

Apologies for the delay in replying, the great grandchildren are leaches. Lovely leaches mind you 😃 Unfortunately, it also does it when I compile from the latest source, and the one previous, before the clickable notifications. The screen in my Biqu B1 is a custom version of the TFT35 e3 V3 I believe, so for now I'm running the build from the B1 repo. With that one, it's so far so good. Just to add. The screen switches to TFT mode, directly after you have confirmed the print in Marlin mode and not when the print actually starts to print. (If that helps).

blueeagle69 commented 4 years ago

I just tried again with the latest source. And sure enough, I started a print in Marlin mode, and as soon as I hit confirm the print, the screen switches to TFT mode, When it does this, the Stop button doesn't respond (as previously mentioned), and also when using other buttons that are working, Pause etc. there are no touch sounds. If I press the Reset button the screen boots up in Marlin mode, which of course was the mode I was in before the screen switched itself to touch mode. And yet again, this is the build that works on my screen. I'm using the version https://github.com/bigtreetech/BIQU-B1/tree/master/Firmware I'm using the build dated 2020-08-15

Hope this helps.

oldman4U commented 4 years ago

What if you start a ticket there: https://github.com/bigtreetech/BIQU-B1/issues

@thisiskeithb answered another ticket there and he is THE specialist.

Finally this repo points to the standard software here, so they should be aware if there is a problem with it.

zonalimitatore commented 4 years ago

The biqu B1 firmware,it's flashable with ftf24? If yes,the problem there isn't at all(with preconpolated),or need to compile from source?

blueeagle69 commented 4 years ago

No the TFT in the B1 is a TFT35. They say it's a variant of the Tft35 e3 v3. But I dont think it is. I'm sure it's a variant of the tft35 v3 (non e3) model. I would like to know what screens people are using that have this issue. I've tried compiling from source and pre compiled. Same issue.

zonalimitatore commented 4 years ago

I've TFT24,but in freetime I can take a look at the entire code

oldman4U commented 4 years ago

It would be important to find the exact pull request (Commit)!which causes this issue. Then it would be possible to contact the engineer and ask him to fix it.

zonalimitatore commented 4 years ago

I can't work on it.....There isn't a source files.Only the .bin The "source" link join up in BTT's repository

blueeagle69 commented 4 years ago

Hi. I just posted on the B1 repo too as advised.