bigtreetech / BIGTREETECH-TouchScreenFirmware

support TFT35 V1.0/V1.1/V1.2/V2.0/V3.0, TFT28, TFT24 V1.1, TFT43, TFT50, TFT70
GNU General Public License v3.0
1.31k stars 1.65k forks source link

[FR] Smart RGB encoder control #1072

Closed LordBBQ closed 3 years ago

LordBBQ commented 4 years ago

It would be very useful to be able to have the encoder LED change colour based on the current printer state, like in marlin when using the touchscreen.

Example: Idle: Off Heater: from blue to red Print: white Completion: green Idle: Off

traffic-light commented 4 years ago

I'm currently working on a firmware change that will change the encoder knob colour when heating (while printing). When heating is done it become the colour you did set in the feature settings When the print is finished it will be green.

When leaving the print menu it will be, again, the colour you did set in the feature settings

I also implemented it so that the neopixel will do the same as it would when printing form marlin: Heating: Blue to red Printing: White Done: Green

I will also make the colour of the knob red when PID tuning is buzzy and green when ready ;-)

I can't test my code. My screen is broken. So you've got to wait ;-)

What screen type do you use? I could send you a binary to test my current progress.

(You can find the code here: https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/compare/master...traffic-light:neopixel_sequential_whileprint?expand=1

It needs some fine tuning. But I hope it works. Can't test it....)

traffic-light commented 4 years ago

A better link:

https://github.com/traffic-light/BIGTREETECH-TouchScreenFirmware_peter/tree/neopixel_sequential_whileprint

(Pasted the wrong one before 😬 )

LordBBQ commented 4 years ago

Thanks. My TFT35 E3 should come soon and I should be able to test it shortly.

thisiskeithb commented 4 years ago

I'm currently working on a firmware change that will change the encoder knob colour when heating (while printing).

Please make this configurable/allow it to be disabled.

traffic-light commented 4 years ago

I'm currently working on a firmware change that will change the encoder knob colour when heating (while printing).

Please make this configurable/allow it to be disabled.

That's already implemented ;-) You can turn it on or off in the feature menu.

I don't see any reason to make it configurable

thisiskeithb commented 4 years ago

That's already implemented ;-)

I’m aware you can change the default knob LED color or on/off state.

I don't see any reason to make it configurable

For users who don’t want the knob color to change while heating/prefer the static (on or off) state instead.

traffic-light commented 4 years ago

I don't see any reason to make it configurable

For users who don’t want the knob colour to change while heating/prefer the static (on or off) state instead.

As already mentioned.. I already implemented this in my code. You can turn off the sequential mode.

(maybe i was not clear for you. but it's implemented in my fork...)

thisiskeithb commented 4 years ago

(maybe i was not clear for you. but it's implemented in my fork...)

I didn’t try your fork. I’m just asking that it be configurable/disabled by default when you put in a PR here.

traffic-light commented 4 years ago

It is configurable in the feature menu. I think I disable it by default

oldman4U commented 4 years ago

Hi. What is the status of the development?

traffic-light commented 4 years ago

The status is: waiting for my package to arrive .. I'm starting to be annoyed by the slooooow delivery...... CGO / Depart from airport 2020-09-12 21:03

深东凤岗仓 / Depart from facility to service provider. 2020-09-04 09:23

深东凤岗仓 / Shipment arrived at facility and measured. 2020-08-25 15:28

深东凤岗仓 / 4px picked up shipment. 2020-08-25 15:28

oldman4U commented 4 years ago

Next time I send you one of mine😎

Peter van Weeterloo notifications@github.com schrieb am Mo. 28. Sep. 2020 um 08:43:

The status is: waiting for my package to arrive .. I'm starting to be annoyed by the slooooow delivery......

CGO / Depart from airport

2020-09-12 21:03

深东凤岗仓 / Depart from facility to service provider.

2020-09-04 09:23

深东凤岗仓 / Shipment arrived at facility and measured.

2020-08-25 15:28

深东凤岗仓 / 4px picked up shipment.

2020-08-25 15:28

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/1072#issuecomment-699809519, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6XKZHDUSNZPBPGJP2WP3TSIAWC5ANCNFSM4REX2BNQ .

traffic-light commented 4 years ago

hahah. that would be nice. The most annoying thing is that they also ship from europe since a short time...

oldman4U commented 4 years ago

BTT? Or a certain store you mean?

Peter van Weeterloo notifications@github.com schrieb am Mo. 28. Sep. 2020 um 09:36:

hahah. that would be nice. The most annoying thing is that they also ship from europe since a short time...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/1072#issuecomment-699835487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6XKZHQH2EUFUITZXJCWR3SIA4GJANCNFSM4REX2BNQ .

traffic-light commented 4 years ago

btt ships skr 1.4 and tft screens (and some more) from europe.

Met vriendelijke groet; Peter van Weeterloo


Van: oldman4U notifications@github.com Verzonden: maandag 28 september 2020 09:38 Aan: bigtreetech/BIGTREETECH-TouchScreenFirmware BIGTREETECH-TouchScreenFirmware@noreply.github.com CC: Peter van Weeterloo info@petrossystems.nl; Comment comment@noreply.github.com Onderwerp: Re: [bigtreetech/BIGTREETECH-TouchScreenFirmware] [FR] Smart RGB encoder control (#1072)

BTT? Or a certain store you mean?

Peter van Weeterloo notifications@github.com schrieb am Mo. 28. Sep. 2020 um 09:36:

hahah. that would be nice. The most annoying thing is that they also ship from europe since a short time...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/1072#issuecomment-699835487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6XKZHQH2EUFUITZXJCWR3SIA4GJANCNFSM4REX2BNQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/1072#issuecomment-699836741, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AI2VWAODET7HV5VEV765OO3SIA4QDANCNFSM4REX2BNQ.

oldman4U commented 4 years ago

Hi traffic-light. Are you still waiting for the TFT? Or are you working on something w?

traffic-light commented 4 years ago

Hi traffic-light. Are you still waiting for the TFT? Or are you working on something w?

Yes... It's still not here.... Still waiting for it to arrive at the airport. And then i've got to wait until the customs think it's okay to send to the Netherlands where i live.

I'll never order again through biqu.equipment. it's horribly slow. And they can't say: Its because of covid19. (Other chinese webshops, like banggood, can deliver 2 times as fast. Im already waiting since 23th of august)

It's a little bit demotivating me to make code and functions for BTT (if you add the bad solution they provide because they screwed something up)

oldman4U commented 4 years ago

Maybe we should further improve your readme first in the meantime and maybe also work on the FR list. Do you have an idea how this could work best?

traffic-light commented 4 years ago

Maybe we should further improve your readme first in the meantime and maybe also work on the FR list. Do you have an idea how this could work best?

Would love to do that. But the problem is that i'm currently do a graduation internship and I've 4 re-exams.. So.. I don't have a lot of time for myself. So I'll have to finish that first...

It should be finished in march. From then on I'm an Embedded Systems Engineer :-P

The PR part: Maybe a message in issues where everyone can post where he/ she is working on.

oldman4U commented 4 years ago

Hey. Good luck!!

Wrong priorities for me, but if you think this is important for you....🤪

traffic-light commented 4 years ago

Haha yes. I wan't to finish it as soon as possible ;-)

My loan is already too high -_-'

oldman4U commented 4 years ago

Don’t ask. My daughter did the BAR in SF yesterday and today after studying law for 6 years. And we have 5 children

Peter van Weeterloo notifications@github.com schrieb am Mi. 7. Okt. 2020 um 23:27:

Haha yes. I wan't to finish it as soon as possible ;-)

My loan is already too high -_-'

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/1072#issuecomment-705203583, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6XKZDZHG2Z7FDKZFN7OXDSJTMNRANCNFSM4REX2BNQ .

traffic-light commented 4 years ago

Aiiii.

A couple of years ago we could receive money from the government when you study and live on your own (without paying it back). But they changed that 5~6 years ago.

So now the only option is to receive a loan from the government....

Outlook for Androidhttps://aka.ms/ghei36 downloaden


From: oldman4U notifications@github.com Sent: Wednesday, October 7, 2020 11:37:26 PM To: bigtreetech/BIGTREETECH-TouchScreenFirmware BIGTREETECH-TouchScreenFirmware@noreply.github.com Cc: Peter van Weeterloo info@petrossystems.nl; Comment comment@noreply.github.com Subject: Re: [bigtreetech/BIGTREETECH-TouchScreenFirmware] [FR] Smart RGB encoder control (#1072)

Don’t ask. My daughter did the BAR in SF yesterday and today after studying law for 6 years. And we have 5 children

Peter van Weeterloo notifications@github.com schrieb am Mi. 7. Okt. 2020 um 23:27:

Haha yes. I wan't to finish it as soon as possible ;-)

My loan is already too high -_-'

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/1072#issuecomment-705203583, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6XKZDZHG2Z7FDKZFN7OXDSJTMNRANCNFSM4REX2BNQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/1072#issuecomment-705207597, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AI2VWANM77VXCOKWCLMKL7DSJTNRNANCNFSM4REX2BNQ.

oldman4U commented 4 years ago

Or to have parents like us and a grandparents with a bit money in the pocket.

Peter van Weeterloo notifications@github.com schrieb am Mi. 7. Okt. 2020 um 23:46:

Aiiii.

A couple of years ago we could receive money from the government when you study and live on your own (without paying it back). But they changed that 5~6 years ago.

So now the only option is to receive a loan from the government....

Outlook for Androidhttps://aka.ms/ghei36 downloaden


From: oldman4U notifications@github.com Sent: Wednesday, October 7, 2020 11:37:26 PM To: bigtreetech/BIGTREETECH-TouchScreenFirmware < BIGTREETECH-TouchScreenFirmware@noreply.github.com> Cc: Peter van Weeterloo info@petrossystems.nl; Comment < comment@noreply.github.com> Subject: Re: [bigtreetech/BIGTREETECH-TouchScreenFirmware] [FR] Smart RGB encoder control (#1072)

Don’t ask. My daughter did the BAR in SF yesterday and today after studying law for 6 years. And we have 5 children

Peter van Weeterloo notifications@github.com schrieb am Mi. 7. Okt. 2020 um 23:27:

Haha yes. I wan't to finish it as soon as possible ;-)

My loan is already too high -_-'

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/1072#issuecomment-705203583 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AM6XKZDZHG2Z7FDKZFN7OXDSJTMNRANCNFSM4REX2BNQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub< https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/1072#issuecomment-705207597>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AI2VWANM77VXCOKWCLMKL7DSJTNRNANCNFSM4REX2BNQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/1072#issuecomment-705210841, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6XKZAGZ7RATGX6VQQOUITSJTOR7ANCNFSM4REX2BNQ .

oldman4U commented 4 years ago

OK. I am working on the FR list and it is almost done.

Not sure how far this project has been going so far, but finally this ticket is s duplicate of #634, so could you please be so kind and close this ticket.

The feature itself will be part of this list of course!

Thank you

Mactastic1-5 commented 3 years ago

I'm currently working on a firmware change that will change the encoder knob colour when heating (while printing). When heating is done it become the colour you did set in the feature settings When the print is finished it will be green.

When leaving the print menu it will be, again, the colour you did set in the feature settings

I also implemented it so that the neopixel will do the same as it would when printing form marlin: Heating: Blue to red Printing: White Done: Green

I will also make the colour of the knob red when PID tuning is buzzy and green when ready ;-)

I can't test my code. My screen is broken. So you've got to wait ;-)

What screen type do you use? I could send you a binary to test my current progress.

(You can find the code here: https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/compare/master...traffic-light:neopixel_sequential_whileprint?expand=1

It needs some fine tuning. But I hope it works. Can't test it....)

What about adding an Auto button to the LED controls on the TFT? There is an OFF button and buttons to change the color, but no AUTO.

traffic-light commented 3 years ago

My screen and mainboard Will be delivered today :-D

oldman4U commented 3 years ago

Holy moly!!!! This is 😊

oldman4U commented 3 years ago

Which mainboard?

traffic-light commented 3 years ago

It's still a dream 😝 But I received it :-)

IMG_20201024_141817

And looks like it's working correctly

traffic-light commented 3 years ago

It's exactly 2 months ago I did place the order ;-)

oldman4U commented 3 years ago

But worth the time 😁 SKR TURBO.

oldman4U commented 3 years ago

It's still a dream 😝

But I received it :-)

IMG_20201024_141817

And looks like it's working correctly

So you don't need any help with connecting and firmware update!!?? A bit disappointing I must say😎

traffic-light commented 3 years ago

Hhahahaha

I received some error when stating the UBL probe. Probing failed... Can't figure out the problem. Can you huys help me? What did i do wrong

See my setup in the image before...

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 6 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.