bigtreetech / BIGTREETECH-TouchScreenFirmware

support TFT35 V1.0/V1.1/V1.2/V2.0/V3.0, TFT28, TFT24 V1.1, TFT43, TFT50, TFT70
GNU General Public License v3.0
1.32k stars 1.65k forks source link

[FR] Toggle for multiple z steppers #1179

Closed Portzal closed 3 years ago

Portzal commented 4 years ago

Including a toggle in .h for multiple Z steppers. This will allow separate settings in TMC options for Z2, Z3, Z4 etc.

Portzal commented 4 years ago

I have just noticed that there is no option to turn off StealthChop either.

radek8 commented 4 years ago

I have just noticed that there is no option to turn off StealthChop either.

If your drivers use UART mode, you have the option to set HYBRID_THRESHOLD from the display menu Why use manual switching when the feature HYBRID_THRESHOLD is available?

Add the option to change parameter M569 to the menu shouldn't be a problem, but is it needed?

radek8 commented 4 years ago

As for multiple Z-axis motors. The display FW should be able to set the same TMC controller parameters to two motors on the same axis. But I don't have this configuration to verify it.

So can you give feedback if you have two stepper motors on the axis? If you change the Current or Hybrid Threshold value. Will there be a change value on the second stepper motor?

Portzal commented 4 years ago

I have made some progress with sorting this issue for myself, but I am still working through the code to find the relevant areas to update. image

radek8 commented 4 years ago

The current parameter for the second Z2 axis is not displayed on the touchscreen because both stepper motors are assumed to operate with the same setting. It is unnecessary to display Z and Z2 if they both have the same value Therefore, use unmodified FW displays.

If it works as I write, it's the expected state, if not, there's a mistake somewhere :-)

Portzal commented 4 years ago

@radek8 I am already well aware of everything you have commented. I prefer the functionality I have in the Marlin simulation mode and see no reason why the touch screen mode does not have the same settings. image

radek8 commented 4 years ago

You did not answer me if the current setting works as I described or there is a problem with it.

I understand that more views in Marin suit you. If it is better for you, use it. BTT produces HW. The software does not solve much, it is rather compiled by the users themselves according to their needs. You can set up to 6 extruders in the configuration file. Unfortunately, practically only 2 can be configured and with other axes X, Y, Z it is similar.

The space for the code in TFT is also limited and the requirements and functions are many. 95% of users of this display do not have a printer with multiple axes or extruders. Those who do not have a weaving printer consider it unnecessary to have other parameters for axes in the menu. Many users also criticize the possibility of setting the current for the second extruder because it does not have it.

The current logic does not seem so bad to me. If I have two stepper motors on the axis, they must be the same and I will need to set the same parameters on them. This can also prevent incorrect operation if you forget to set the current on the second motor and he would then lose the steps.

radek8 commented 4 years ago

I want a bid for the second extruder, you want a bid for the second z axis someone will come up with the fact that it has 4 motors on the Z axis and someone else will have two motors on all axes .... submenu in the Parameters menu currently has the ability to edit 5 items. It would have to be put in more offers. That would be confusing. Or the entire Parameters menu would have to be redesigned.

Portzal commented 4 years ago

Another missing piece in the puzzle appears to be the ability to adjust Junction deviation.

radek8 commented 4 years ago

PR is already ready for the Junction parameter #1192

Can you answer my question above?

You look for bugs and you call it a circus. You can help clear the errors or stop using the display. No one is forcing you.

radek8 commented 4 years ago

The display lacks a lot of functions, but they can be supplemented. So do you want to get involved and help improve and test new features?

radek8 commented 4 years ago

Udělal jsem určitý pokrok v třídění tohoto problému pro sebe, ale stále pracuji v kódu, abych našel příslušné oblasti k aktualizaci. obraz

Send the file you edited, I'll tell you what you're missing :-)

radek8 commented 4 years ago

@radek8 I am already well aware of everything you have commented. I prefer the functionality I have in the Marlin simulation mode and see no reason why the touch screen mode does not have the same settings.

Marlin compiles for a specific printer configuration. The display must be as universal as possible in order to be able to control as many different printers with different configurations ...

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 7 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.