search

bigtreetech / BIGTREETECH-TouchScreenFirmware

support TFT35 V1.0/V1.1/V1.2/V2.0/V3.0, TFT28, TFT24 V1.1, TFT43, TFT50, TFT70
GNU General Public License v3.0
1.31k stars 1.65k forks source link

[BUG] Preheat titles color #1232

Closed gordo3di closed 3 years ago

gordo3di commented 3 years ago

Description

Steps to reproduce

  1. Change background color to white.
  2. Preheat menu titles are also white.

Hardware Variant

TFT35 v3

TFT Firmware Version & Main Board Firmware details

CONFIG_VERSION 20200810

Additional Information

In preheat.c I changed the title color to the code below. I'm not great with github commits so I was hoping someone could add this. Thank you.

//set preheat title properties
  lvIcon.lines[0].h_align = CENTER;
  lvIcon.lines[0].v_align = TOP;

  //GTL changed to match font color
  GUI_SetColor(infoSettings.font_color);
  //lvIcon.lines[0].fn_color = LCD_WHITE;

  lvIcon.lines[0].text_mode = GUI_TEXTMODE_TRANS;
  lvIcon.lines[0].pos = preheat_title;
  lvIcon.lines[0].large_font = false;
oldman4U commented 3 years ago

Hi gordo3di.

Great to "see" you again.

You mean preheatMenu.c, right?

I can show you how to make PR's, it is a 10 min action.

oldman4U commented 3 years ago

So, this would be correct?

Screenshot 2020-11-05 at 22 48 33
gordo3di commented 3 years ago

Hey @oldman4U great to esee you as well haha. Yes that's correct. I think I'm working in too many files at once.

Basically I use VS Code to program and I just download the latest repository as a zip file every now and then. For some reason I've tried to grasp the git concept but it seems like I'm not getting it lol. I've tried several tutorials but do you have any suggestions?

I see.you have also gotten these tickets really wrangled in!

radek8 commented 3 years ago

https://desktop.github.com/

oldman4U commented 3 years ago

;-)

I am working with GitHub on Mac,..... aaaah radek8 my friend was faster;-)

In GitHub you then make a local repository which includes the software you would like to change. Every change is recognised by GitHub and once you are done, you save it to your local repo and after that you simply upload your changes to the server repository. It makes automatically a ticket with a PR - it is MAGIC;-)

Tickets. Slowly the system is usable and many users are really helping a lot, some not...;-) But I had 5 children, I am used to the - I hate you and I wish I would never be born - stuff. For this shit I am really too old.

gordo3di commented 3 years ago

@radek8 I'll definitely work on it this weekend. Thank you

Tickets. Slowly the system is usable and many users are really helping a lot, some not...;-) But I had 5 children, I am used to the - I hate you and I wish I would never be born - stuff. For this shit I am really too old.

@oldman4U Haha. I have employees but no kids yet... The system is definitely more useable.

oldman4U commented 3 years ago

It will improve further. My goal is still <25 tickets and I expect this to happen by the end of the year. Gurmeet installed a Bot which finally will close all those completely useless old tickets. ;-)

Have fun with GitHub

oldman4U commented 3 years ago

How has your GitHub knowledge improved over the weekend?

gordo3di commented 3 years ago

No time lately. I'm trying to move so lots of packing. Soon though! I spent some time today on the BTT UPP power loss/backup module and PLR. Do you want me to close this topic?

On Mon, Nov 9, 2020 at 4:12 PM oldman4U notifications@github.com wrote:

How has your GitHub knowledge improved over the weekend?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/1232#issuecomment-724280800, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXO26MK4YQZLIIKZX4ZR5DSPBLKRANCNFSM4TL3CVFA .

-- Gordon LaPlante Architect // Designer // Maker e gordo3di@gmail.com

gCreate LLC Founder // Partner w: gcreate.com http://www.gcreate.com/ fb: facebook.com/gcreate3d http://www.facebook.com/gcreate3d t: @gCreate3d http://www.twitter.com/gcreate3d

oldman4U commented 3 years ago

Keep it open until we know who will fix this.

oldman4U commented 3 years ago

Hi.

Hope you are doing fine.

I will change the issue with my next PR #1380

Please check and let me know if this is correct

Thank you

gordo3di commented 3 years ago

Hi.

Hope you are doing fine.

I will change the issue with my next PR #1380

Please check and let me know if this is correct

Thank you

Looks good. I did notice that sometimes my text will revert back to white after a print has completed and I head back to the preheat menu. I'm not sure why. I'll keep investigating.

oldman4U commented 3 years ago

Hi. Gurmeet made some additional changes. Because he is the one who knows the code best I expect it works now. 😁

gordo3di notifications@github.com schrieb am Mo. 14. Dez. 2020 um 17:06:

Hi.

Hope you are doing fine.

I will change the issue with my next PR #1380 https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/pull/1380

Please check and let me know if this is correct

Thank you

Looks good. I did notice that sometimes my text will revert back to white after a print has completed and I head back to the preheat menu. I'm not sure why. I'll keep investigating.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/1232#issuecomment-744540870, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6XKZHFN7NP3M7POZHATKLSUYZZNANCNFSM4TL3CVFA .

gordo3di commented 3 years ago

Perfect! I'll close this ticket. Thank you

oldman4U commented 3 years ago

👍🏻

gordo3di notifications@github.com schrieb am Mo. 14. Dez. 2020 um 17:26:

Closed #1232 https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/1232 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/1232#event-4110167347, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6XKZGRPG3P62JOFZFCJLLSUY4DFANCNFSM4TL3CVFA .

github-actions[bot] commented 6 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.