search

bigtreetech / BIGTREETECH-TouchScreenFirmware

support TFT35 V1.0/V1.1/V1.2/V2.0/V3.0, TFT28, TFT24 V1.1, TFT43, TFT50, TFT70
GNU General Public License v3.0
1.3k stars 1.65k forks source link

[BUG] controller fan option interferes with part cooling fan reading #1701

Closed dielectric-code closed 3 years ago

dielectric-code commented 3 years ago

Description

When enabling a controller fan in config.ini the part fan reading is wrong.

Steps to reproduce

  1. set fan_count : 1 and fan_crtl_count: 1 in config.ini
  2. update config.ini
  3. set the part cooling fan to any value i.e. 100%,
  4. the display will alternate between F0 and Fctrl
  5. reading of Fctrl is ok
  6. reading for F0 (part cooling fan) will read OK for a second or two, then read 0

Expected behavior

Correct reading of F0 and Fctrl Actual behavior

Wrong reading of F0 after a second or two

Hardware Variant

TFT35 E3 V3

TFT Firmware Version & Main Board Firmware details

firmware form Copy folder compiled on 8 march 2121

radek8 commented 3 years ago

I can confirm, after the last few PRs, the fan speed is not displayed on the status screen.

oldman4U commented 3 years ago

dielectric-code

Which mainboard do you have. Are you sure that you have to activate the ctrl fan? Using a single part cooling fan I can control the fan without a problem using the Touchscreen and Marlin Emulation mode on an SKR E3 DIP without having the ctrl count set to 0. Haven't tried it with my SKR PRO, which has more controllable fans.

bigtreetech commented 3 years ago

I confirmed it and it will be fixed soon.

oldman4U commented 3 years ago

Hi. Fix is available. Please check

dielectric-code commented 3 years ago

@oldman4U , @bigtreetech , Works perfectly now. Thanks, that was quick!

github-actions[bot] commented 6 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.