bigtreetech / BIGTREETECH-TouchScreenFirmware

support TFT35 V1.0/V1.1/V1.2/V2.0/V3.0, TFT28, TFT24 V1.1, TFT43, TFT50, TFT70
GNU General Public License v3.0
1.31k stars 1.65k forks source link

[BUG] UBL Grid Size is 10 #1824

Closed Airconaaron closed 3 years ago

Airconaaron commented 3 years ago

Description

Currently under my own personal marlin config I set my max grid size to 15 as follows

  #define MESH_INSET 10              // Set Mesh bounds as an inset region of the bed
  #define GRID_MAX_POINTS_X 15      // Don't use more than 15 points per axis, implementation limited.
  #define GRID_MAX_POINTS_Y GRID_MAX_POINTS_X

However the TFT 35 UBL probe appears to only look at a 10x10 grid. I see that the latest configuration.h under src/ folder has a 15x15 max grid, perhaps the latest release just doesn't contain these fixes?

Steps to reproduce

  1. Set 15x15 grid in marlin for board 2.Enable and use UBL on TFT 35 LCD
  2. Save mesh to s1, board and screen crash.
  3. View mesh in terminal via G29 L1; G29 T, see that output grid is only 10x10

Expected behavior I expect that saving my grid will not crash my screen. I expect that the output from a G29 T will be a 15x15 Grid

Actual behavior G29 T outputs a 10x10 grid, board crashes during UBL.

Hardware Variant

TFT 35

TFT Firmware Version & Main Board Firmware details

x.x.27, Marlin 2.0.7.2 SKR mini v2

Additional Information

digant73 commented 3 years ago

Firstly, I think that you could not have reset the EEPROM. If a 10x10 grid is probed and also G29 T provides a 10x10 grid size it can mean that the previous Marlin fw was configured with a 10x10 grid size and that a 10x10 grid was saved on EEPROM. Second (and probably the problem), I think that you could have reached the resource limits on Marlin fw. With a 10x10 UBL grid size, my Marlin reached 94% of RAM and 91% FLASH. The fw had a lot of bugs (crash starting a print from onboard SD, pause and M600 not working, stuttering of the nozzle etc...). Try to reset EEPROM first. If it doesn't work, simply avoid to configure a 15x15 UBL grid size on Marlin. The max grid size on TFT fw was extended to 15x15 in the recent past, but this is only a limit on the grid displayed by the Mesh Editor and not the grid size to be probed by Marlin. The UBL process is entirely controlled by Marlin. If you see a 10x10 grid was probed, you must check on Marlin side

oldman4U commented 3 years ago

What is the status of the reported issue?

oldman4U commented 3 years ago

Please help the community and close the ticket once you do not need it anymore. Thank you

oldman4U commented 3 years ago

@Msq001

This user does not reply to his own ticket and digant could not verify the reported issue in his own code.

Please check and close it.

Thank you

github-actions[bot] commented 6 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.