[BUG] (Filament Sensor don't work in touch mode, if it is connected to the base board)

Ari-SSO commented 3 years ago

Description

The runout filament sensor do not function correctly in touch mode, my environment:

BTT TFT35 v3.0
BTT SKR 1.3
Filamente sensor connected to SKR 1.3 board, PIN 1.29
Firmware TFT35 v3.0: BIGTREE_TFT35_V3.0.27.x.bin
Firmware SKR 1.3: Marlin Bugfix (Version 2.0.9, according to the configuration.h file)

I have tried various combinations of the Marlin configuration, and the M119 command always behaves correctly in the absence or presence of filament when i use a host software connected by USB cable to my PC. Testing from Repetier Host, it also behaves correctly as the configuration changes with the M412 command. I have tried all the possible combinations of the M412 command, along with the configuration of the TFT35 v3.0 screen, plus the different combinations of Marlin. And it has always worked fine from Repetier Host. I use the BTT TFT35 v3.0 in Marlin Mode then it also runs perfectrly and detect correctly the filament, but If i use it in Touch Mode, I have always obtained the following, regardless of the marlin configuration, the M412 command, and the existence of filament in the sensor:

Filament sensor ON: With or without filament, it always says that filament is missing and cannot continue printing. Filament Sensor OFF: It never detects whether or not it has filament (I guess this is correct). Filament Sensor SMART: It starts printing and after a few seconds, it says that there is no filament. When pressing "Resume" it continues but says again that there is no filament one or two minutes later (This regardless of whether or not there is a filament). And the same always repeats for ever.

The problems appears only when i use the tocuh mode in the display (The mode that normaly I use).

Steps to reproduce

Configure filament sensor in marlin firmware
run M119 to verify thar the sensor detect correctly the ,presence or absence, of filament.
Set the TFT to touch mode
Set, in TFT, the runout filament sensor ON
Print something with and without filament in the the printer (Always display a message reports that there is not filamente)
Repeat 4 and 5, but with OFF and SMART option.

Expected behavior If there is filamente then print normaly, else stop printing, (This if you set the filamente sensor on, if off contiune printing without filament)

In touch mode, depending on runout filament sensor setting in TFT: Filament sensor ON: With or without filament, it always says that filament is missing and cannot continue printing. Filament Sensor OFF: It never detects whether or not it has filament (I guess this is correct). Filament Sensor SMART: It starts printing and after a few seconds, it says that there is no filament. When pressing "Resume" it continues but says again that there is no filament (This regardless of whether or not there is a filament). And the same thing always repeats.

Hardware Variant

Firmware TFT35 v3.0: BIGTREE_TFT35_V3.0.27.x.bin

TFT Firmware Version & Main Board Firmware details

BTT TFT35 v3.0 BTT SKR 1.3 Filamente sensor connected to SKR 1.3 board, PIN 1.29 Firmware TFT35 v3.0: BIGTREE_TFT35_V3.0.27.x.bin Firmware SKR 1.3: Marlin Bugfix (Version 2.0.9, according to the configuration.h file) BIGTREETECH-TouchScreenFirmware-Configurations.zip Marlin.zip

Additional Information

Include a ZIP file containing your Configuration.h or use Pastebin and paste a link in this issue.
Provide pictures or links to videos that clearly demonstrate the issue.

kisslorand commented 3 years ago

Put M75 in the start of your gCode file. If I had a cent for each time I wrote this sentence... Wouldn't it be easier to search around and check it it has been discussed or not? The TFT has no way to know if filament sensor connected to the motherboard is triggered or not unless someone (in our case Marlin on the motherboard) tells him so. Marlin is not transmitting filament sensor info unless there's a print ongoing. So Marlin doesn't know that the TFT is actually printing, not just sending gCodes, unless someone (in our case the TFT) tells him so. M75 tells Marlin that there's a print ongoing and Marling knowing this will send info about the filament sensor connected to it.

I hope it helps...

guruathwal commented 3 years ago

The filament sensor option in the TFT is only for connecting the sensor to the TFT itself. In your case, the sensor is connected to the mainboard so the filament sensor settings on the TFT are useless. you will have to control it through marlin mode or through gcodes.

oldman4U commented 3 years ago

We should add a note to the filament sensor part of config.ini that the Settings here have only to be activated in case the sensor is connected to the TFT and that you have to add M75 to the start gCode in case it is connected to the mainboard. Who wants to add this?

Ari-SSO commented 3 years ago

if you add M75 at start code, may be also add M77 at end code, for consistency. If you are OK, then i will add it in the config.ini...

oldman4U commented 3 years ago

Please do so. But please add a note and do not change the gCode itself.

Ari-SSO commented 3 years ago

In which branch i must add this? in develop branch?

Thanks!

oldman4U commented 3 years ago

You just make a PR. BTT merges it correctly.

Ari-SSO commented 3 years ago

it is done, i hope it is ok.

Thank to all of you!

bigtreetech commented 3 years ago

fixed in #2017, so close here

oldman4U commented 3 years ago

Thank you. I will change the order of the text and the text itself a bit and hope this is ok for you.

Happy printing

oldman

Ari-SSO commented 3 years ago

Yes, please!... I Know that my english is not the best of the world.

Thanks!

oldman4U commented 3 years ago

No problem at all. It was more the order of the information and to make it shorter. Check my PR.

Happy printing

github-actions[bot] commented 6 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

bigtreetech / BIGTREETECH-TouchScreenFirmware