search

bigtreetech / BIGTREETECH-TouchScreenFirmware

support TFT35 V1.0/V1.1/V1.2/V2.0/V3.0, TFT28, TFT24 V1.1, TFT43, TFT50, TFT70
GNU General Public License v3.0
1.31k stars 1.65k forks source link

[BUG] Probing corners using UBL "L Corner" #2815

Closed blazejkarwowski closed 9 months ago

blazejkarwowski commented 1 year ago

Description

Probing corners using UBL "L Corner"

Steps to reproduce

  1. Update TFT35 Firmware with bin.
  2. Go to L corners via Movement -> Bed Level -> UBL -> L Corner.
  3. Select any corner
  4. Bed gets probed
  5. No result showed on screen

Expected behavior Bed height should be displayed

Actual behavior Nothing is changing on the screen

Hardware Variant

BTT TFT35 E3 V3.0

TFT Firmware Version & Main Board Firmware details

BIGTREE_TFT35_V3.0_E3.27.x.bin Marlin bugfix-2.1.x

Additional Information

Config of printer https://pastebin.com/YdqK0FMG Working video https://youtu.be/lQHiDFrEKaw

kisslorand commented 1 year ago

I tested but cannot reproduce the issue you have. Please make sure you have the Marlin dependencies set as instructed here: https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware#marlin-dependencies

Note: the "SERIAL_FLOAT_PRECISION 4 (in Configuration_adv.h)" is not needed, it's obsolete.

thephantom1492 commented 1 year ago

TFT70 here.

This is a "regression" in marlin code. They killed the SERIAL_FLOAT_PRECISION, and fixed it to 2 digits. This break the functionality.

Marlin nightly of 2023-05-14 is working fine. Not sure when they actually broke the code, but possibly commit ed4e22b of 2023-06-04.

kisslorand commented 1 year ago

They just reverted that change, SERIAL_FLOAT_PRECISION is back.

thephantom1492 commented 1 year ago

I do not see any sign of reversal. The last commit is 5 days ago. All I see is a bug report.

kisslorand commented 1 year ago

Yes, you're right, I remembered wrong.

kisslorand commented 1 year ago

I made a fix for it but for 2 weeks I am unable to make any more PR.

github-actions[bot] commented 6 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.