bigtreetech / BIGTREETECH-TouchScreenFirmware

support TFT35 V1.0/V1.1/V1.2/V2.0/V3.0, TFT28, TFT24 V1.1, TFT43, TFT50, TFT70
GNU General Public License v3.0
1.32k stars 1.65k forks source link

[FR] [ST7920_Simulator.c] Add a character generator in order to use klipper #290

Closed derBG closed 3 years ago

derBG commented 4 years ago

Many users of your skr boards use klipper (https://github.com/KevinOConnor/klipper).

Please add a character generator to TFT / src / User / API / UI / ST7920_Simulator.c to make your tft24 screen and similiar usable.

Further information can be found in the Klipper issue at https://github.com/KevinOConnor/klipper/issues/2231

Your community will appreciate it very much

Thank you very much

erik23de commented 4 years ago

I'd like to expicitely agree to the post before. Please, add a character generator!

DeviousPenguin commented 4 years ago

I use Klipper, and an currently unable to use my TFT24 with it.

I looks like the emulation of the reprap display needs a character generator.

If you could add a character generator that would be really nice, as I'd like to use the TFT24 with the printer I am building.

DeviousPenguin commented 4 years ago

For anyone looking to do this, the ST7920 datasheet is a good resource:

ST7920 provides character generation ROM supporting 8192 16 x 16 character fonts and 126 8 x 16 alphanumeric characters. It is easy to support multi languages application such as Chinese and English. Two consecutive bytes are used to specify one 16x16 character or two 8x16 half-height characters. Character codes are written into DDRAM and the corresponding fonts are mapped from CGROM or HCGROM to the display drivers.

kakou-fr commented 4 years ago

yes please add it

tpipits commented 4 years ago

+1

AnHardt commented 4 years ago

The original font-ROM of the ST7920 is about 130 kByte. Even for the larger processors of the displays, this is more than 50% of the flash memory. Better do something more useful with the memory.

JohnEdwa commented 4 years ago

The ASCII half-height HCGROM is just 16K-bits, which is 2kB. The rest is for chinese characters, which I would assume are rarely needed with 3D printers.

bigtreetech commented 4 years ago

The original font-ROM of the ST7920 is about 130 kByte. Even for the larger processors of the displays, this is more than 50% of the flash memory. Better do something more useful with the memory.

BTT's touch screen has an external flash(W25Qxx) storage bitmap fonts, so don't worry about this. This function should be easy to implement, but I'm busy recently, so I don't have time to test this. After a new version is released this week, I will start to implement this function

combolek commented 4 years ago

I would like to register another request to get this implemented. Thanks!

mbgroot commented 4 years ago

I'm very much looking forward to a solution to this problem. The printer is without screen :(

kakou-fr commented 4 years ago

no news ?

dushyantahuja commented 4 years ago

This would be great.

TakeThisBanana commented 4 years ago

I would also love to see the TFT35 E3 implemented.

Lyngtoft commented 4 years ago

Brilliant, just switched to klipper, would love to use my tft35

Depman commented 4 years ago

+1

bigtreetech commented 4 years ago

image

image

Debuging... It will be realized soon

mbgroot commented 4 years ago

the font will depend on the klipper or is it hard to set in the screen firmware?

JohnEdwa commented 4 years ago

It's set by the screen, this whole thing is because Klipper uses the internal text generator on the display driver for the text, which was missing from this simulator. And as it is a simulator, it needs to include that character rom data as well which means it should be rather easy to swap it for a different font - if one exists or can be easily created, that is.

eddietheengineer commented 4 years ago

@bigtreetech thank you for working on this, I know a lot of people are excited to have some high quality display options!

eboblin commented 4 years ago

@bigtreetech any updates on this issue?

TakeThisBanana commented 4 years ago

image

image

Debuging... It will be realized soon

How is the debugging comming along? I am really looking forward to using my tft35 e3 again :D

JeffMedd commented 4 years ago

I'll add a +1 of interest for this feature also! Thanks for prioritizing the development of this, it will be very much appreciated.

maketo3D commented 4 years ago

+1 very interested on it.

RomRider commented 4 years ago

Still a bunch of glitches, but this is great progress!! IMG_20200525_201843

RomRider commented 4 years ago

@bigtreetech, when the printer starts with the latest master branch version, I have to switch to touchmode and back to marlin mode before something is displayed on the screen else it stays black. I have SPI_ReEnable(0); set + the other function updated and a TFT35 v3. Also I have a SKR1.3 board.

EDIT: SPI_ReEnable(1); doesn't fix the initial black screen issue.

TakeThisBanana commented 4 years ago

image

image

Debuging... It will be realized soon

How are things comming along?

cskozlowski commented 4 years ago

Any update on this front? I have a tft35 display laying around that I would really like to use with klipper on my Voron 2.4 build.

TakeThisBanana commented 4 years ago

How is the status of developement?

GrumpaV2 commented 4 years ago

Just bought TFT 70 in big summer sale to use with Klipper on SKR 1.4.... Please implement this in firmware update

marvelous240 commented 4 years ago

Would also love to see this implemented soon!

kakou-fr commented 4 years ago

I tried on klipper with a TFT 24 : 1) a lot of glitch 2) 90% of the time, when the print boot, the display only show " .... simulator" 3) when the display work, after 1-2 hour, it stop working correctly and only display the bed icon on all the screen

jariivanoff commented 4 years ago

Adding a wish to get this fully implemented! :-D

weaslus commented 4 years ago

yeah, this is going to be my browser homepage for the foreseeable future...

GrumpaV2 commented 4 years ago

I should have just bought Duet and Paneldue! What a waste of 65 bucks... Maybe I can hook it up to my kids Ender 3

aklef commented 4 years ago

@bigtreetech bump! Devs, we love you. Do you need anything? Can I help? A glass of water perhaps? We just want y’all to keep us updated please!

RomRider commented 4 years ago

I'm not a dev here, it was just the result on my printer 😊 For me it works "quite alright" with some of the glitches you can see in the picture above.

oldman4U commented 4 years ago

Could you please be so kind and close this ticket. Your feature request is covered in the pinned Feature Request ticket #1177

Thank you

RomRider commented 4 years ago

This isn't in any way related to #1177 and is not fixed completely.

oldman4U commented 4 years ago

@RomRider

Sorry typo #1170 not 1177.

Thank you

RomRider commented 4 years ago

But why would you want to close this FR since it is not fully implemented? I don't understand the logic? While it is under development, this thread is used for discussion around it. Am I missing something here?

oldman4U commented 4 years ago

Because there is now one centralized place instead of many tickets on a page where nobody can find it.

Jérôme W. notifications@github.com schrieb am Mi. 21. Okt. 2020 um 00:05:

But why would you want to close this FR since it is not fully implemented? I don't understand the logic?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/290#issuecomment-713167182, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6XKZHOB6HABXG44JNVQK3SLYCTDANCNFSM4KE7ZH4Q .

RomRider commented 4 years ago

That doesn't make any sense. Discussions on several features shouldn't happen in one mega thread it's going to be a massive mess!

Each feature should get its own discussion thread and then you can maintain your issue which references them all if you want...

oldman4U commented 4 years ago

Are you the owner of this ticket?

There is a link to this ticket for reference FR Ticket and because it is closed does not mean that it can not be used.

But if you are the owner and you prefer a ticket on page 2 or even further behind over a pinned ticket just let me know. Such tickets like inactive tickets will be removed from the FR Ticket in about one week.

weaslus commented 4 years ago

Are you the owner of this github? What is your role here?

oldman4U commented 4 years ago

I am a user like you.

Looking at other repositories like the SKR v1.3 I try to keep this one usable.

What are you doing to help the community to make this open source project a success?

weaslus commented 4 years ago

Im not goimg to mince words here. Appologies to those who dont care to recieve these strings of emails.

You seem like the self appointed sherrif. Your tone is tiresome. What happens if you leave the github due to boredom, busy work life, death? You want your way. Does your way really require that this feature request be closed, when it is still an active request?

oldman4U commented 4 years ago

I will hand it over - except I am death.

In case you want to do it let me know and we can do it right now.

Again. What are you doing? I can not develop so I try to help this way and I am sure there is also something you could do.

This ticket can remain opened no need to close it. Are you the owner?

weaslus notifications@github.com schrieb am Mi. 21. Okt. 2020 um 09:46:

Im not goimg to mince words here. Appologies to those who dont care to recieve these strings of emails.

You seem like the self appointed sherrif. Your tone is tiresome. What happens if you leave the github due to boredom, busy work life, death? You want your way. Does your way really require that this feature request be closed, when it is still an active request?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/290#issuecomment-713378505, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6XKZDTXHDVVCES6AYUQELSL2GW7ANCNFSM4KE7ZH4Q .

marvelous240 commented 4 years ago

Shut up. All of you.

Sent from my iPhone

On Oct 21, 2020, at 3:53 AM, oldman4U notifications@github.com wrote:

 I will hand it over - except I am death.

In case you want to do it let me know and we can do it right now.

Again. What are you doing? I can not develop so I try to help this way and I am sure there is also something you could do.

This ticket can remain opened no need to close it. Are you the owner?

weaslus notifications@github.com schrieb am Mi. 21. Okt. 2020 um 09:46:

Im not goimg to mince words here. Appologies to those who dont care to recieve these strings of emails.

You seem like the self appointed sherrif. Your tone is tiresome. What happens if you leave the github due to boredom, busy work life, death? You want your way. Does your way really require that this feature request be closed, when it is still an active request?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/290#issuecomment-713378505, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6XKZDTXHDVVCES6AYUQELSL2GW7ANCNFSM4KE7ZH4Q .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

oldman4U commented 4 years ago

;-)

kakou-fr commented 4 years ago

I resolved my problems, I brought a Fysetc MINI 12864 :). It works and I can control thecolor of the screen/button ...