bigtreetech / BIGTREETECH-TouchScreenFirmware

support TFT35 V1.0/V1.1/V1.2/V2.0/V3.0, TFT28, TFT24 V1.1, TFT43, TFT50, TFT70
GNU General Public License v3.0
1.27k stars 1.63k forks source link

code reduction & cleanup #2920

Closed digant73 closed 2 months ago

digant73 commented 2 months ago

Once the code is pretty stable since some time now, scope of this PR is an overall cleanup and code reduction (no code is changed).

IMPROVEMENTS:

PR STATE: Ready for merge

rondlh commented 2 months ago

Changed 281 files, amazing!!! Well done like always.

Tiny issue: in User\Menu\ScreenSettings.c, line 19

static const char * const labelMarlinType[ITEM_MARLIN_TYPE_NUM] =
{
  // item value text(only for custom value)
  "128x64",
  "20x4"
};

This is only needed if the emulator is enabled, so probably best to guard it (#ifdef HAS_EMULATOR) or push it down to the HAS_EMULATOR section.

digant73 commented 2 months ago

yes, I will apply the filter on the next PR (I will complete the cleanup)