TFT35 V3.0: counter values shown instead of position values after home

bigtreetech / BIGTREETECH-TouchScreenFirmware

support TFT35 V1.0/V1.1/V1.2/V2.0/V3.0, TFT28, TFT24 V1.1, TFT43, TFT50, TFT70

GNU General Public License v3.0

1.3k stars 1.64k forks source link

TFT35 V3.0: counter values shown instead of position values after home #434

Closed blupeace closed 4 years ago

blupeace commented 4 years ago

The main page shows counter values instead of position values after home command. Steps to reproduce the issue:

build BIGTREE_TFT35_V3.0 using VSCode and PlatformIO
copy .pio/build/BIGTREE_TFT35_V3.0/BIGTREE_TFT35_V3.0.25.2.bin to SDCard
copy ./Copy to SD Card root directory to update - Unified Menu Material theme/TFT35 folder to SDCard
insert the SDCard into TFT35 and flash the new version
go to Menu->Movement->Home->Home
wait the homing
got to Menu->Movement->Move and perform any movement

Expected behaviour: PositionOK

Actual behaviour: PositionActual

The first occurence of this issue appears at commit a0e7296196bfdaf7530edcae01e7008fbdccb836

Powerprobot commented 4 years ago

I can confirm the issue. I make a programming- fork for me and my version work but it is not for public. i wil work for a better recognition in the code but i am a novice programmer (I start with the commodore64 and coded hard with assembler but the time overrun me) I hope the original programmer will fix this issue soon. The reason is that Marlin would change the output from single Axis coordinates to coordinates with additional steps.

Powerprobot commented 4 years ago

@blupeace you find my repositories here: TFT35_1.2 Attention: the config is cofigured as TFT35 1.2 with some additions and changes for me.

blupeace commented 4 years ago

Thank you very much. I am going to check it. Unluckily I cannot try if it works right now because yesterday I burn my main board (I already ordered a brand new one). Whenever I will receive the board, I will let you know if it works properly.

Nascire commented 4 years ago

@Powerprobot : I had the same problem as @blupeace - just implemented your changes on latest master and I again have the correct position shown - thanks for sharing! Maybe create a PR as long as no other/finer solution is done?

guruathwal commented 4 years ago

This issue was caused by recent changes in M114 reporting in Marlin firmware. See Marlin issue thread here: https://github.com/MarlinFirmware/Marlin/issues/17255

Powerprobot commented 4 years ago

I see. I updated both, Marlin and TFT35. I will delete my fork, because it is not longer needed. The Updates work well.

github-actions[bot] commented 5 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.