bigtreetech / BIGTREETECH-TouchScreenFirmware

support TFT35 V1.0/V1.1/V1.2/V2.0/V3.0, TFT28, TFT24 V1.1, TFT43, TFT50, TFT70
GNU General Public License v3.0
1.31k stars 1.65k forks source link

[BUG] Issue with Leveling #985

Closed Guilouz closed 4 years ago

Guilouz commented 4 years ago

When I start a leveling on touch screen, it launches 2 leveling in a row. When I save this 2 leveling after complete, when I restart my printer, nothing is stored.

When I run G29 via Terminal and an M500 all is OK.

It happens since this PR : https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/commit/44088a8cfeac6bdfe482716bd5497adc27400469

I use AUTO_BED_LEVELING_BILINEAR and when I take a closer look at the code in leveling.c :

_while(infoMenu.menu[infoMenu.cur] == menuAutoLeveling) { key_num = menuKeyGetValue(); switch(key_num) { case KEY_ICON0: storeCmd("G28\n"); if (infoMachineSettings.enableubl == 1) { storeCmd("G29 P1\n"); storeCmd("G29 P3\n"); storeCmd("M118 A1 UBL Complete\n"); } else { storeCmd("G29\n"); leveled = true; } break;

It seems G29 P1 and G29 P3 are runs however these commands are used when AUTO_BED_LEVELING_LINEAR is used and not for AUTO_BED_LEVELING_BILINEAR

Something else that i noticed, in Leveling menu on touch screen I have 'Unified Bed Leveling' and not 'Bilinear Bed Leveling' if I refer to the translation file.

bigtreetech commented 4 years ago

Hello, you can set #define ENABLE_UBL_VALUE to 0 (disable Unified Bed Leveling) or 2(Auto-detect) https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/blob/221943d1284d876e29677680f1a8752ca1a07b11/TFT/src/User/Configuration.h#L248 Maybe it should be 2 in default, I will test and modify it. Thanks for you feedback!

Guilouz commented 4 years ago

@bigtreetech Just try with auto-detect parameters and it's look good. I make a PR or you do it ?

radek8 commented 4 years ago

I have the same problem. This option cannot be changed via Config.ini. You will need to add this option to Config.ini so that it can be set without compiling a new FW

github-actions[bot] commented 6 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.