Fix hard coded chopper timing & R_SENSE override, fix compile warnings - Githubissues

bigtreetech / MMU2-DIP

MMU 3-axis stepper control

31 stars 13 forks source link

Fix hard coded chopper timing & R_SENSE override, fix compile warnings #21

Closed thisiskeithb closed 2 years ago

thisiskeithb commented 2 years ago

Description

Fix chopper timing being set to CHOPPER_DEFAULT_12V no matter what you set CHOPPER_TIMING to.
Change default CHOPPER_TIMING to *_24V since the MK3/S/+ and most printers are 24V these days.
Allow R_SENSE override, add correct RSENSE value for BTT TMC5160s
Fix some compiler warnings

*_19V is available as a CHOPPER_TIMING option in the code, but is an unusual voltage. Perhaps it can be dropped?

And I'll ask again since I'm not sure how this works 🙂: When should version/build numbers be bumped?

https://github.com/bigtreetech/MMU2-DIP/blob/e572273be209d6570e306391e8ce6c29f232ae24/firmware/MMU2/src/version.h#L6-L7

bigtreetech commented 2 years ago

And I'll ask again since I'm not sure how this works 🙂: When should version/build numbers be bumped?

The version/build numbers need be bumped when the source code be modified.