search

bihealth / digestiflow-demux

:spaghetti: Digestiflow Demultiplexing Tool
MIT License
2 stars 4 forks source link

Add capability to parse and check user-given bases mask (demux_reads … #7

Closed messersc closed 5 years ago

messersc commented 5 years ago

…from web) for bcl2fastq2 and picard

holtgrewe commented 5 years ago

Generally looks good, we need a tweak for the CI and minor changes needed to code.

messersc commented 5 years ago

Generally looks good, we need a tweak for the CI.

@holtgrewe Is there a better way than adding noqa to the offending snakemake. lines?

holtgrewe commented 5 years ago

@messersc bandit should only be tweaked for tests

holtgrewe commented 5 years ago

@messersc noqa is the way to go

messersc commented 5 years ago

bandit should only be tweaked for tests

As I understand it, it is only possible to either skip a class of tests or to exclude files/directories. But it is currently not possible to only disable a test (B101) for a given directory (tests)

https://github.com/PyCQA/bandit/issues/346

holtgrewe commented 5 years ago

OK, fine.

holtgrewe commented 5 years ago

Please make sure to squash and use a rebase commit.