bihor / fp_newsletter

TYPO3 plugin for newsletter subscription and unsubscription. Used table: tt_address. A log is written.
https://extensions.typo3.org/extension/fp_newsletter/
GNU General Public License v3.0
7 stars 18 forks source link

TCA migration #92

Closed seirerman closed 8 months ago

seirerman commented 8 months ago

'Check TCA Migrations' in Install Tool/Upgrade says:

The TCA field 'sys_language_uid' of table 'tx_fpnewsletter_domain_model_log' is defined as the 'languageField' and should therefore use the TCA type 'language' instead of TCA type 'select' with 'foreign_table=sys_language' or 'special=languages'.

Probably only a small issue, but I thought I'd mention it here.

Tested on TYPO3 11.5.36 with fp_newsletter 4.2.0, but Configuration/TCA/tx_fpnewsletter_domain_model_log.php of fp_newsletter 6.4.3 still uses

                'type' => 'select',
                'special' => 'languages',
seirerman commented 8 months ago

Message now confirmed with fp_newsletter 6.4.3, but only on a TYPO3 installation with a single language. No idea how this affects multilanguage installations.

bihor commented 8 months ago

I will take a look at it next week

bihor commented 8 months ago

OK, I have changed this in version 7.0.0.