Closed lehecht closed 8 months ago
You have to use the php-cs-fixer
branch as base for this PR, otherwise the composer fix
command will fail. Also, you can use the php-cs-fixer
branch as target for this PR, so this PR will not include all the changes of #652, too.
use the
php-cs-fixer
branch as target for this PR
You mean as new base branch? So php-cs-fixer branch replaces the master branch?
I meant like this (locally):
php-cs-fixer
branchgit cherry-pick
the existing commit from this branch)php-cs-fixer
branch as targetBut it won't matter any more because I'll merge #652 in a few minutes. Then you just have to merge the new master
into php-cs-action
(or I just do it).
Now it's working. You can now try to add annotations.
Cs2pr throws an error, which I cannot reproduce. I'm on it, trying to fix this problem. If you know something about it, @mzur, please let me know.
When you use the composer command you have to do it like this:
- composer fix -vvv --dry-run --format=checkstyle | cs2pr
+ composer fix -- -vvv --dry-run --format=checkstyle | cs2pr
Otherwise the arguments will not be forwarded to the CS Fixer command.
Thank you!
Resolves #676 by adding cs-php action.