search

biigle / core

:large_blue_circle: Application core of BIIGLE
https://biigle.de
GNU General Public License v3.0
12 stars 16 forks source link

Improve navbar (for mobile) #683

Closed mzur closed 8 months ago

mzur commented 8 months ago

So I was fed up with the navbar behavior on mobile for the final time. While we won't optimize all of BIIGLE for mobile anytime soon, at least the navbar should work. Here are the changes:

before after
desktop view:
Screenshot from 2023-10-23 16-30-33 Screenshot from 2023-10-23 16-30-38
Screenshot from 2023-10-23 16-44-16 Screenshot from 2023-10-23 16-43-19
mobile view:
Screen Shot 2023-10-23 at 16 31 06 Screen Shot 2023-10-23 at 16 31 04
Screen Shot 2023-10-23 at 16 31 13 Screen Shot 2023-10-23 at 16 31 10

@dlangenk Comments?

dlangenk commented 8 months ago

@dlangenk Comments?

Really like that this is working right now. I have to say from a visual standpoint I liked the old design better without the outlines arround the objects, less button looking buttons, but I guess it's still worth it to have everything working without that much hassle.

mzur commented 8 months ago

Really like that this is working right now.

You mean you like the current behavior of the navbar (i.e. it gets larger on mobile and possibly hides content like in the annotation tool)?

I have to say from a visual standpoint I liked the old design better without the outlines arround the objects [...]

I stole that idea from GitHub again :smiley: But if you have a strong opinion against it maybe we have to ask more people what they think. I've now updated the background color of the buttons so they are less "intruding":

image

dlangenk commented 8 months ago

Really like that this is working right now.

You mean you like the current behavior of the navbar (i.e. it gets larger on mobile and possibly hides content like in the annotation tool)?

Nope I mean the new layout (the "after")

I have to say from a visual standpoint I liked the old design better without the outlines arround the objects [...]

I stole that idea from GitHub again 😃 But if you have a strong opinion against it maybe we have to ask more people what they think. I've now updated the background color of the buttons so they are less "intruding":

image

Yes, I like that better. Can keep it that way I'd say.

mzur commented 8 months ago

Alright, thanks!