biigle / core

:large_blue_circle: Application core of BIIGLE
https://biigle.de
GNU General Public License v3.0
12 stars 16 forks source link

Small video loading spinner does not disappear #695

Closed mzur closed 6 months ago

mzur commented 7 months ago

With the following actions, the small video loading spinner (on the top left of the video timeline) no longer disappears, even if nothing is loading:

  1. Open a video in a volume with multiple videos
  2. Click on a later time in the timeline to move the video forward, the small loading spinner will appear
  3. Immediately click on the "next video" button
  4. The big loading spinner (colorful steering wheel) will appear while the new video is loading
  5. When the new video is loaded, the big loading spinner disappears but the small one won't disappear

While the (small) loading state is active, no clicks are allowed to jump the video time in the timeline, too.

To fix this, cancel the (small) loading action and state when the user changes to the next video.

lehecht commented 6 months ago

I struggle to recreate this bug. Is the video already running before jumping to a later time stamp? The only thing that creates this bug for me, is if I hold the right arrow key for a couple of seconds. The next videos are displayed but the small grey spinner does not disappear any more. Do you think this behaviour has to do with this bug or is another one?

mzur commented 6 months ago

Your machine is probably faster than mine 😄 But what you describe sounds like what I see:

Screencast from 15.12.2023 09:13:31.webm

Basically, the loading state for the little spinner has to be reset when a new video was loaded.