search

biigle / core

:large_blue_circle: Application core of BIIGLE
https://biigle.de
GNU General Public License v3.0
12 stars 15 forks source link

Sometimes the video position is not reset #724

Closed mzur closed 8 months ago

mzur commented 9 months ago

Sometimes when I move the video position to a certain time and then switch to the next or previous video in the volume, the position is not reset to 0. Here is an example (wait for it):

Screencast from 15.12.2023 10:43:38.webm

lehecht commented 9 months ago

Is there a reason why this line is not used? If this is commented in, everything seems to work again.

mzur commented 9 months ago

No idea why this is there to be honest. I added it 5 years ago when I first implemented that component. I guess that I chose to use the seeked event instead. Maybe timeupdate already fires when the user clicks (i.e. currentTime is updated) whereas seeked only fires once the video actually loaded at that position.

Thinking about it, maybe using timeupdate instead of seeked may be a better UX because the user has instant feedback. There is still the loading state with the little spinner and the time indicator is gray until seeked is fired. What do you think?

lehecht commented 9 months ago

I agree that it would be better to use timeupdate only. It would also avoid redundant method calls when the video playback position is seeked.