search

biigle / geo

:m: BIIGLE module to explore images on a world map
GNU General Public License v3.0
0 stars 1 forks source link

Geojson api #24

Closed mzur closed 4 years ago

mzur commented 4 years ago

This PR tracks the progress of the student project to implement a GeoJSON enpoint for use in a GIS.

References #18

mzur commented 4 years ago

On a general note, I follow this guide to write my git commit messages. This is just personal preference, of course.

mzur commented 4 years ago

@sagunshre Can you please allow edits from maintainers in this PR? Then I can fix the failing tests.

mzur commented 4 years ago

I wasn't able to fix the tests right now. The tests themselves are fine but the GitHub action that runs the tests fails in this particular case (because this PR adds a new package as dependency). This can be ignored for this PR.

My attempt to fix the action can be found in the geojson-test-action branch.

mzur commented 4 years ago

You can also implement tests for the new Image/Volume/ProjectAnnotation controllers.

mzur commented 4 years ago

Visual validation of the fixed annotation coordinates:

  1. Closeup of image 20150813_224129_IMG_3368.JPG and the annotation coordinates without rotation in green (the image isn't rotated as well) and with rotation in pink. The green coordinates match the positions in the annotation tool. The rotation looks plausible (approx. 90° counterclockwise rotation). Screenshot from 2020-07-01 15-19-45

  2. Annotation coordinates of all annotations with the image center locations in black. Screenshot from 2020-07-01 15-17-45

mzur commented 4 years ago

In addition to my review comments above and the tests for the new controllers, you can implement a 404 response if no images with the required lat, lng, yaw and distance_to_ground metadata can be found.