search

biigle / laserpoints

:m: BIIGLE module to perform a heuristic laser point detection on images
GNU General Public License v3.0
0 stars 1 forks source link

Allow manual LP detection for all images #23

Closed mzur closed 5 years ago

mzur commented 6 years ago

With the new width and height attributes of images, we don't need to download the actual image for manual LP detection. We could allow LP detection even for tiled images.

Also we should ditch the px attribute of the JSON (what do we need it for anyway?).

@dlangenk can we safely remove these lines? https://github.com/BiodataMiningGroup/biigle-laserpoints/blob/345b80c85ea36a1ef1cee51e212b0c52fd25e374/src/resources/scripts/detect.py#L18-L19

mzur commented 6 years ago

Actually we should be able to do everything that detect.py does in PHP directly. No need to call an external script.

mzur commented 5 years ago

I judged the validation if the image width and height attributes were already set as needlessly complex. This check would be required if the attribures were to be used for manual laser point detection. In addition, laser point detection for tiled images probably does not make sense, too, as these images most likely do not contain laser points. Users can set the image area with the image metadata upload.