search

bijection / sistine

Turn a MacBook into a Touchscreen with $1 of Hardware
https://www.anishathalye.com/2018/04/03/macbook-touchscreen/
MIT License
3.25k stars 192 forks source link

[function- segment] [Why RGB2LAB & !BGR2LAB] #11

Open ashishgupta1350 opened 6 years ago

ashishgupta1350 commented 6 years ago

Why did you segment image using RGB2LAB when you could have used BGR2LAB and set the threshold values on the third layer as 140-230. It gives the same result.

antimatter15 commented 6 years ago

I believe the code that we're using is technically incorrect (since OpenCV uses BGR instead of RGB). We noticed this at some point and tried fixing it, but for some reason the correct implementation performed more poorly.

ashishgupta1350 commented 6 years ago

Can you please send us the correct code? Let us see if we can debug and find errors in the correct code? I think we should be able to make a descent attempt at correcting it. We hope to scale the project across all platforms. It's done for the most part. I'll then design a GUI for calibrating the settings in real time and remove the need for installing dependencies on any pc.

Me and Ishika are computer science students working at you code as a hobby project. So far we have made sure your code works for windows and Linux.