Fix redesign bugs - Githubissues

bijij / ViewImage

Extension to re-implement the "View Image" and "Search by image" buttons into google images.

MIT License

780 stars 106 forks source link

Fix redesign bugs #165

Closed qsniyg closed 5 years ago

qsniyg commented 5 years ago

The redesign features a bug where the View Image button gets repeated (although not Search By Image), and highlights a bug in the script where either visibility: visible or translate3d(0px, 0px, 0px) elements are chosen, instead of only those that contain both CSS properties. In the redesign, this occasionally causes the script to fail due to off-screen containers containing the visibility: visible property.

qsniyg commented 5 years ago

Not sure why it still shows Travis is failing, the issue it mentioned was fixed in https://github.com/bijij/ViewImage/pull/165/commits/214869c9b5ff271c5c6bd69ebfb682cea43964d6, and trying eslint manually works without the issue.

bijij commented 5 years ago

Very weird since it passed on merge