Google UI redesign breaks functionality

bijij / ViewImage

Extension to re-implement the "View Image" and "Search by image" buttons into google images.

MIT License

784 stars 108 forks source link

Google UI redesign breaks functionality #166

Closed ghost closed 5 years ago

ghost commented 6 years ago

This extension no longer functions on the new Google Image UI. I'm not too experienced with this otherwise I'd submit a PR.

bijij commented 5 years ago

Still stuck on the old one myself so supporting changes isn't really possible for me.

qsniyg commented 5 years ago

@bijij I fixed the problem in the PR I sent :) For some reason, Google reverted the redesign for me, so I'm currently unable to test anymore, but after the fix, it worked fine when it was enabled for me.

bijij commented 5 years ago

I'll update the versions live tomorrow.

h-h-h-h commented 5 years ago

This is what it looks like for me:

Bild ansehen is German for View Image.

Those are the links:

2x correct image
1x wrong image A
3x wrong image B

qsniyg commented 5 years ago

@h-h-h-h Have you updated to the latest version? The PR I sent should have fixed that issue.

h-h-h-h commented 5 years ago

@qsniyg:

I have the latest version from addons.mozilla.org (v2.1).

I'll wait till your PR rolls out over the normal update channel. I'm currently back to the old design of Google Images anyway (it just happens without me doing anything).

bijij commented 5 years ago

I forgot to update the release Firefox version, sorry about that should be live in the next few hours

Mijyuoon commented 5 years ago

I am still getting the duplicated "View image" button if you switch between related images in the gallery thing under the buttons.

h-h-h-h commented 5 years ago

Yeah, it's still v2.1 on https://addons.mozilla.org/de/firefox/addon/view-image/.

bijij commented 5 years ago

Mozilla didn't approve without me verifying something and I missed the email. sorry bout that