bijij / ViewImage

Extension to re-implement the "View Image" and "Search by image" buttons into google images.
MIT License
780 stars 106 forks source link

Buttons missing in new images layout #181

Closed terrorist96 closed 4 years ago

terrorist96 commented 5 years ago

Similar to #161

Search Google for image, either open result (All sizes) or click on a visually similar image. https://www.google.com/search?q=Canyonwoods+Drive&tbm=isch&source=iu&ictx=1&tbs=simg:CAEStAIJ1-YEoZYjTqMaqAILELCMpwgaYgpgCAMSKP0Utgr4FdEUwAr9FdUU_1xT8FL4KxjikKuY-uirlPrEqwCq1KrwqzTgaMFKaz9T2q91cUR0ZA-yd4W_1AxPpRPj0TFq9vVazVJ1d3XIWii4UIxsYnoWx9iSTUAiAEDAsQjq7-CBoKCggIARIEMl4EbgwLEJ3twQkaoAEKGQoGZXN0YXRl2qWI9gMLCgkvbS8wMzh0OF8KJQoSbGFuZHNjYXBlIGxpZ2h0aW5n2qWI9gMLCgkvbS8wOTBwYnIKJAoRc2VjdXJpdHkgbGlnaHRpbmfapYj2AwsKCS9tLzA3amIxYwoaCgdldmVuaW5n2qWI9gMLCgkvbS8wNG14MzIKGgoHbWFuc2lvbtqliPYDCwoJL20vMDJwdmJiDA&fir=zF8DJ6WBYLYLTM%253A%252CFzV-7_94IgS1pM%252C_&vet=1&usg=AI4_-kTVNPFJR3RCvIOCdBKjEyDnQkI2VA&sa=X&ved=2ahUKEwiZtb3vjPHjAhUnTd8KHSJfA9oQ9QEwAnoECAAQBA#imgrc=zF8DJ6WBYLYLTM:&vet=1

image

terrorist96 commented 5 years ago

But the View Image button does appear if I search via text and go to the images tab (but the search by image button is missing still).

https://www.google.com/search?rlz=1C1GCEV_en&biw=1680&bih=903&tbm=isch&sa=1&ei=lfJKXenmM6uOggf0xbrwAg&q=test&oq=test&gs_l=img.3..0l10.12281.12582..12701...0.0..0.85.303.4......0....1..gws-wiz-img.......35i39j0i67.2GaVKFNgzr8&ved=&uact=5#imgrc=LLSqc5L4G3MOTM:

image

tolgabalci commented 5 years ago

Some images have the View image globe button and some images do not. Haven't found a pattern for which ones do and which ones do not.

bijij commented 5 years ago

@terrorist96 in the picture shown there the search by image link is just below where you circled.

as for the original issue post, google seems to be doing something different there where the sidebar section is loading multiple images at all stacked on top of each-other and hiding all the other images based on the one you clicked on.

Might take a while to find a solution which fixes that without breaking all the other implementations google has in place.

bijij commented 5 years ago

To add to this. if you just click around all the images on that page you linked at random eventually the view image button will begin appearing as expected.

terrorist96 commented 5 years ago

@terrorist96 in the picture shown there the search by image link is just below where you circled.

Where? image

To add to this. if you just click around all the images on that page you linked at random eventually the view image button will begin appearing as expected.

Can confirm this is true.

bijij commented 5 years ago

To the right of the "Images may be subject to copyright" it's just hyperlinked text rather than a button on the redesign for now.

terrorist96 commented 5 years ago

Oh I see it now. But it's not there in the very first image I posted.

terrorist96 commented 5 years ago

Here's another issue. After clicking around to get the buttons to appear, sometimes the links will be for other images. For example, I clicked the Search by image link for one picture but it opened a tab with another picture's search result instead.

bijij commented 4 years ago

This seems to have resolved itself with Google changing the layout again. Or at least has for me. Closing for now.

If you're having issues perhaps discuss in #188

terrorist96 commented 4 years ago

It's more broken than before for me. Don't see the View Image or search by image links anywhere. But I'll follow issue #188