search

bijij / ViewImage

Extension to re-implement the "View Image" and "Search by image" buttons into google images.
MIT License
780 stars 106 forks source link

Clicking "View image" opens blank page #207

Open f4ringo opened 4 years ago

f4ringo commented 4 years ago

I see blank page when I'm trying to open full size image

Steps

  1. Open any image in Google
  2. Click "View Image"
  3. See blank page

Pics 1. image

  1. Opens this image

–––––––––––––––– Mac OS Catalina Chrome 76.0.3809.132 ViewImage v3.2.2 (mac x86-64) - ru

JustusGS commented 4 years ago

Same issue occurring for me. I assume Google changed something in the last few days.

MacOS Catalina 10.15.2 Chrome 79.0.3945.130 v3.2.2 (mac x86-64) - en_US

SteveBaker commented 4 years ago

Yeah - me too - on all platforms. Looks like Google did something.

bijij commented 4 years ago

At the moment I can't repro unfortunately. likely A:B testing on Google's end 😞

ikeblaster commented 4 years ago

@bijij I can confirm the issue. It looks like google is creating some temporary container with base64 image and then swaps it with new container which contains the image from real URL. But not always - if you switch image below preview (in right pane), then it just swaps img src attribute. Using mutation observer on the .n3VNCb (which are image previews) attributes seems to be reliable in both cases.

Please can you test this fixed version on your end? I wonder whether class tvh9oe was already present in OCT19 or we need to split it into JAN20. Sorry for not creating PR, too much hassle for one file when I don't know if works for everyone. :/

https://pastebin.com/h5GgVUnH

Tested in chrome and FF.

bijij commented 4 years ago

This seems to work for me, I'm not sure if tvh9oe always existed or not.

I'll be happy to commit this and push a new version if you're okay with that.

bijij commented 4 years ago

sorry @ikeblaster forgot to mention you.

ikeblaster commented 4 years ago

@bijij Of course, please do.

bijij commented 4 years ago

Gone ahead and published a copy with those changes, lets see if it fixes it for people.

Reonu commented 4 years ago

@bijij I don't see any updates. Is it not published yet on the addon store?

bijij commented 4 years ago

@Leon422 what version is your extension currently?

Reonu commented 4 years ago

@bijij v3.2.2 (win undefined) - undefined. I'm on Firefox. The addon store says the extension was last updated 3 months ago.

bijij commented 4 years ago

@Leon422 I repushed to AMO should be live in a bit.

Reonu commented 4 years ago

@bijij It finally updated, and it's working fine again. Thanks!

MrNotSoNice commented 4 years ago

Thanks! It's working!

f4ringo commented 4 years ago

Thanks @bijij It’s working!

needforsuv commented 4 years ago

It still shows the thumbnail if you click view image for larger images where only the thumbnail loads

needforsuv commented 4 years ago

if the main image isn't one of the main ones

tsuliwaensis commented 4 years ago

I'm using v3.2.2 of the UserScript version on Chrome 81.0.4044.43, and this is still broken.

JohannesMP commented 2 years ago

This issue is still the case and seems to be occurring more frequently

JohannesMP commented 2 years ago

The 'Google Images Restored' extension appears to not suffer from this issue - https://chrome.google.com/webstore/detail/google-images-restored/ncndcebmkibkhopclfdjfacgfholcghi/related

Specifically for a given image result where with the 'View Image' extension exhibits this bug, viewing the same search and having the same search result with the 'Google Images Restored' extension installed will not cause this bug, and all images seem to both render their previews as well as as open the image as desired.

For the time being I would therefore recommend anyone that is encountering this issue with the 'View Image' extension to consider 'Google Images Restored' instead.