Not Working in Firefox 90.0.2 or Chrome 94.0.4590.2

[adanvdo]

The add-on is no longer working in Firefox 90.0.2 or Chrome Version 94.0.4590.2 (Official Build) canary (64-bit)

On google image search, only the "Visit" button is shown when previewing an image.

Windows 10 x64 Firefox 90.0.2 Chrome Version 94.0.4590.2 (Official Build) canary (64-bit)

[nicolaasjan]

I can confirm this issue. It would be nice if it can be fixed (a lot of bad reviews lately...).

[theshindigg]

I'm on chrome 92.0.4515.107, and have the same issue

[devilbear]

I run several versions of both Firefox and Chrome for testing purposes and can confirm this is happening in all versions I have of both Firefox and Chrome, even as far back as Firefox Developer Edition 56 and Chrome 66.0.3359.139 - as well as the latest versions, of course, but others already mentioned those.

[ner00]

Same here, Firefox 90.0.2 (64-bit), Win10

As a temporary fallback, I've been using Tampermonkey with this userscript: https://github.com/Procyon-b/make-gis-great-again/raw/master/gis-vib.user.js

Not sure if this might be of use to fix this extension: https://github.com/Procyon-b/make-gis-great-again/commit/55f326bef35d5ece5a511cdc5cfd438cb343c1b7#diff-f63c64dfb756cfee16e61848a05a8b76c57a79e042dbab033c4227c648031dec

[bijij]

Hi, I've currently not got access to a computer but I've attempted a fix from mobile, no way to test unfortunately.

I've pushed it out to web stores, hopefully it resolves the issues.

If not I can hopefully have a fix out in the next 12 hours, PRs always welcome though.

[nicolaasjan]

Hi, I've currently not got access to a computer but I've attempted a fix from mobile, no way to test unfortunately.

I've pushed it out to web stores, hopefully it resolves the issues.

If not I can hopefully have a fix out in the next 12 hours, PRs always welcome though.

Thanks! Just got the update in Firefox 90.0.2 and it works again:

[bijij]

Update, chrome rejected the most recent update from their store.

I am unsure if this is evidence that the extension fix did not work for that reviewer, or a blatant attempt by Google to stop this extension from reaching the store.

I'll re-release to the chrome web store today.

[davidtderrick]

I suspect the latter!

[bijij]

Personally, I'm suspecting the reviewer couldn't see a "search by image" button, which I am aware does not appear for some users at the moment and rejected the application.

I've temporarily resubmitted a version which omits references to this feature from the application, I'm hoping tomorrow I can release a version with the feature fully working again, at least for users who see the current google image results page.

[davidtderrick]

It's working fine now for me on Firefox 91.0b9 (64-bit). Thank you.

[adanvdo]

can confirm working on Firefox 90.0.2 (64-bit) still not working in chrome though

[bijij]

The chrome update has been pending a review from Google for the past 10 hours, I'll provide another update when I hear from Google.

[win98se]

Didn't work on Edge 92.0.902.62 using Userscript version, changing line 127 to visitButton = container.querySelector('.ZsbmCf[href], a.J2oL9c'); works. (As in changelog)

[absay]

Still doesn't work on my end, FF 90.0.2 64-bit.

Tried to reinstall and still no luck.

[devilbear]

It worked for me in all versions of Firefox right after the update went live... but now it's once again not working. I think Google changed the element again overnight...?

[davidtderrick]

Oh wow. Now it has stopped working again for me too in Firefox 91.0b9 (64-bit).

[ner00]

I think Google changed the element again overnight...?

This is improbable, I'm using the unchanged userscript mentioned above (https://github.com/bijij/ViewImage/issues/231#issuecomment-890337040) and it still works fine.

[bijij]

This is improbable, I'm using the unchanged userscript mentioned above (#231 (comment)) and it still works fine.

Google has a habit of using a different DOM for different people, it's possible that a 3rd new version rolled out today I need to accommodate.

Though the extension still works for me so, someone it doesn't work for will need to find the change and make a PR for it.

[ner00]

Google has a habit of using a different DOM for different people

The thing is that the ViewImage extension don't work for me either, nor does its userscript version, but the other usescript I linked works all the same since 3 days ago. This means that Google changed something else, but the other userscript can cope with it while ViewImage cannot.

[bijij]

The thing is that the ViewImage extension don't work for me either, nor does its userscript version, but the other usescript I linked works all the same since 3 days ago. This means that Google changed something else, but the other userscript can cope with it while ViewImage cannot.

are you on chrome or FF? The chrome webstore version is out of date because google is seemingly leving it in pending limbo.

[ner00]

are you on chrome or FF?

FF 90.0.2 I'm looking at both codes, but I'm afraid I don't have enough knowledge to spot what makes one work over the other.

Not sure if this can be useful: https://jsfiddle.net/0vmeLx9j/

[devilbear]

Of interest: the linked userscript doesn't seem to be working for me in Firefox 56 (Developer Edition) or Firefox 90 (also Developer Edition). Once I saw it won't work in either of those on my end, I didn't bother checking the versions in between, but I assume it's the whole "different DOM" issue at play.

[ner00]

the linked userscript doesn't seem to be working for me

Yeah, it's really weird, for me the gis-vib.user.js script works with Tampermonkey in Firefox 90.0.2 (Standard), Chrome 92.0.4515.131 (Standard), and Tor Browser 10.5.2 (Firefox 78.12.0esr). I tried in incognito and... well, Tor.

[quoid]

I'm using the userscript through my manager in Safari. The newest (and previous) stopped working.

To get it to working I changed:

viewImageButtonText = viewImageButton.querySelector('.pM4Snf');

to

viewImageButtonText = viewImageButton.querySelector('span');

I believe the reason it was failing for me was that the userscript reckons the version is OCT19, so it targets the .pM4Snf element, which is null. That breaks the functionality that adds the button. It's not throwing an error in the console perhaps because it is not injected into the page context due to the strict CSP?

The class of the span element in the button right now seems to be KSvtLc, but I am targetting the span element in case that class is dynamic or changes soon.

Also, my userscript manager doesn't, yet, support .tld so I need to change the @include values to:

// @include         http*://*.google.*/search*tbm=isch*
// @include         http*://*.google.*/imgres*

[devilbear]

I installed this extension's userscript (as opposed to the one linked in a comment) and made the suggested changes above and it didn't work for me. However, I changed FEB18 and JUL19 the same way - replacing the class with span, and this seemed to fix the userscript for me. I also had to change the .tld to * as described.

[bijij]

I'll be releasing a newer version of the extension today which hopefully fixes is this for most if not all users.

Google once again rejected the extension for the same reason as before, so chrome is still stuck a version behind for now.

Hoping an updated version will fix that.

[absay]

@bijij Thanks for the hard work. Working with Google's stuff can be a true PITA, so having fixes and knowing this project is still maintained is always appreciated.

By the way, will the fix include the "Search by image" link/button to work again? It's been missing from quite some time now, and it's one of the things that I found most appealing when I installed this.

[bijij]

I've just published v3.5.0 to AMO / Chrome webstore, pending their approval.

At least for me this reinstates both the view image and search by image buttons for the new google images DOM. I'll be looking into removing reliance on hardcoded classnames from now on to reduce the chances of this occuring.

[devilbear]

Thanks so much for your hard work on this! Just updated the extension in Firefox (tested 56 & 90 Developer Editions) and it's working now.

[xscd]

@bijij could you update the userscript version too? Thanks. https://gist.github.com/bijij/58cc8cfc859331e4cf80210528a7b255

[ctwhome]

it seems to not be approved yet, that is a pity. thanks for the work

[BL4CKBL4D3]

Hi, the solution for Chrome 92 is really simple: 1.- Download this and extract it: https://github.com/bijij/ViewImage/archive/refs/heads/master.zip 2.- Go to chrome://extensions/ and enable Developer mode 3.- Click on "Upload unzipped" and select the extracted folder of the previously downloaded file

Support screenshot:

And that's it View Image 3.5.0 Successfully installed

[nicolaasjan]

@BL4CKBL4D3 It works that way, however I get the error: Unrecognized manifest key 'browser_specific_settings'.:

    "browser_specific_settings": {
        "gecko": {
            "id": "{287dcf75-bec6-4eec-b4f6-71948a2eea29}"
        }
    },

Error is gone after deleting that part from manifest.json

[Edit] Here's the .crx file (if you trust me): https://dl.dropboxusercontent.com/s/zw1dajs3e3vo5i8/ViewImage.zip

[Edit2] See comment below.

[nicolaasjan]

Just got the 3.5.0 update from the Chrome Web Store.

[adanvdo]

This is now working for me in both Chrome Version 92.0.4515.131 (Official Build) (64-bit) and Firefox 90.0.2 (64-bit) I'm going to close this issue