search

bijij / ViewImage

Extension to re-implement the "View Image" and "Search by image" buttons into google images.
MIT License
784 stars 108 forks source link

"Open in new tab" doesn't open in new tab #238

Closed o-r-i-z-u-r-u closed 8 months ago

o-r-i-z-u-r-u commented 2 years ago

Running Brave 1.36.109 Chromium: 99.0.4844.51

Any suggestions?

FeBe95 commented 2 years ago

Had the same problem with Firefox 98. Went into debugging and found this piece of code:

chrome.contextMenus.onClicked.addListener(
    (info, tab) => {
        // [...]
        if (info.menuItemId === 'ViewImage-SearchByImage') {
            chrome.permissions.request({
                permissions: ['tabs'],
                origins: [tab.url],
            }, (granted) => {
                if (granted) {
                    // [...]

For me, the tabs permission wasn't granted in my extension settings (about:addons in Firefox):

grafik

Enabling both options fixed the issue for me.

Splinter7149 commented 2 years ago

For me, the tabs permission wasn't granted in my extension settings (about:addons in Firefox):

grafik

Enabling both options fixed the issue for me.

@FeBe95 thank you for this, i was looking for so long online until i came across this solution