search

bijij / ViewImage

Extension to re-implement the "View Image" and "Search by image" buttons into google images.
MIT License
780 stars 106 forks source link

Upgrade to Manifest V3, reduce errors, tune permissions #255

Closed funblaster22 closed 1 year ago

funblaster22 commented 2 years ago

Upgrade manifest v3: Renamed entries in manifest

Reduce errors: Add onInstalled listener, which fixes Unchecked runtime.lastError: Cannot create item with duplicate id ViewImage-SearchByImage

Tune permissions: Replace tabs with activeTab permission, which do longer prompts permission every time

bijij commented 2 years ago

Hi @funblaster22 thanks for doing this, I'll take some time tomorrow to review this, just a note for now this would likely be shipped as v4 since moving manifest version imo is breaking enough. so might be worth changing that once you've got time!

funblaster22 commented 2 years ago

Ok, I bumped the version but accidently made a merge conflict in the process sorry 😞

bijij commented 1 year ago

@funblaster22 Since manifest V3's pretty much ready for firefox I'll take some time to look into merging this in in the coming weeks. Thanks again for doing this!

Saibamen commented 1 year ago

in in the coming weeks

;)

bijij commented 1 year ago

This was manually rebased to handle support for Firefox. Thanks for this.