bijij / ViewImage

Extension to re-implement the "View Image" and "Search by image" buttons into google images.
MIT License
780 stars 106 forks source link

"VIew image" button appears, but doesn't do anything #259

Closed Reonu closed 2 years ago

Reonu commented 2 years ago

Describe the bug The view image button is there, but it doesn't do anything

To Reproduce Click the button

Expected behavior It should open the image

System Information

Additional context Example URL: https://www.google.com/search?q=among%20us%20crewmate&tbm=isch&tbs=ic:trans&client=firefox-b-d&hl=es&sa=X&ved=0CAMQpwVqFwoTCPi95rKFwfgCFQAAAAAdAAAAABAC&biw=2048&bih=991#imgrc=dd4ojpkkzW4IGM

ner00 commented 2 years ago

Works fine for me though.

Reonu commented 2 years ago

I swear it doesn't work for me :(

ner00 commented 2 years ago

Try clearing the browser's cache (careful not to delete cookies), reload Google Images with CTRL+R, remove the extension, close/open Firefox, reinstall extension, retry. It usually doesn't need this much hassle though.

GoblinKisser commented 2 years ago

Having the same problem. Tried those steps, still not working for me.

ner00 commented 2 years ago

Not sure then. Have also tried in a refreshed version of Firefox and also worked fine there. Does it show an URL at all when you hover the button?

Just to cover all bases, can you report the version of the extension (as specified in the browser's extensions section)?

Also, open Dev Tools and check the console for any errors related to the extension when loading the Google Images page.

Lastly, inspect the "View Image" button element and share a screenshot or the html code for it.

GoblinKisser commented 2 years ago

Version is 3.6.5.

For errors, I have this: image

When inspecting, I get this: image

image

ner00 commented 2 years ago

The top image with the errors might be a good clue that something is being blocked, although the fact that the button appears in the first place doesn't seem to indicate that it's this particular extension. I may be wrong, but it might be blocking multiple extensions that could be the reason or not - try disabling all other extensions temporarily aside from "View Image" to see if that makes any difference.

Btw, I notice you didn't answer to my other question: Does it show an URL at all when you hover the button? I mean, in the bottom-right corner of the browser where target URLs usually appear when over a link.

As for the inspection, I would have hoped that it showed the inspection of the actual button, which is not the case in the screenshots above, it would look more like this: firefox_ye2XHFF3pg

Anyway, I think @bijij is probably better equipped to advise on what could be the cause here.

GoblinKisser commented 2 years ago

Oh sorry I missed that other question. There is a url appearing when I hover. Also, for the inspection, I clicked inspect over the View Image button and got what I posted so I don't know what to do to get the html you posted. Disabling all but view image did make the button work again though, so I'm going to re-enable them one by one to see if it's a specific one blocking it.

Edit: Just re-enabled one by one, and it stopped working when I turned uBlock Origin back on.

Edit 2: Disabled all but uBlock Origin and View Image, and it still didn't work. Looks like there's some conflict between the two?

0Cut commented 2 years ago

Same behaviour here - FF 101.0.01

Additional info: url appears on hover right click "open link in new tab" works correctly (shows image in new tab) Disabling uBlock Origin extension => Left click on "View Image" button works as intended

Reonu commented 2 years ago

Since apparently it's uBlock Origin breaking it, I've reported the issue to the uBlock Origin devs

ner00 commented 2 years ago

Well, glad you at least made some progress, it's just very weird since I also have uBlock Origins installed and do not have this issue. Are you using the default uBlock lists or some more aggressive blocking lists?

Btw, this is mine on Google Images page:

TlEu31Uf4O

GoblinKisser commented 2 years ago

Here's how it looks for me. image

I do have some extra stuff besides the default, although I've had them selected for so long I don't remember what is and isn't default anymore, and this issue only just started happening to me the other day.

ner00 commented 2 years ago

Fair enough. Anyway, the two shouldn't be interfering with each other. My guess is that it is possible that uBlock or a third-party list they use may have updated some target objects which are being prevented to be injected by View Image. It's just a guess, but doesn't really solve anything.

nicolaasjan commented 2 years ago

It's weird. I have to click multiple times and then the button works...

Reonu commented 2 years ago

The "uBlock Annoyances" filter which was the one causing the issue has been updated and this has been fixed. In the uBlock Origin settings, click the button to purge all caches, then update your filters, it will work again.

nicolaasjan commented 2 years ago

Well, this issue is closed as completed now, but I still have the issue that multiple clicks on the button are needed. Do I have to open a new issue for this?

Reonu commented 2 years ago

I guess? For me it works first try everytime now