search

bijij / ViewImage

Extension to re-implement the "View Image" and "Search by image" buttons into google images.
MIT License
780 stars 106 forks source link

"Permissions needed" showing on the Extensions button when not on a Google site #273

Closed SigmaTheDJ closed 1 year ago

SigmaTheDJ commented 1 year ago

Since the most recent update to the extension, when you're not on a Google site, a green dot appears underneath the Extensions button in Firefox's toolbar: -

1

This is caused by the View Image extension: -

2

3

I cannot see any way to stop this from happening so I assume it's a bug, albeit a minor one that doesn't affect the core functionality.

The expected behaviour would be for View Image to not request permissions for any sites. Permissions are already granted for lots of different Google sites in the extension's own permissions list and the extension is only used with Google's image search sites.

I'm using version 4.0.0 of the extension with Firefox 115.0.2 on Windows 10.

onestepbeyond commented 1 year ago

Same here. Permission granted for all Google domains (or one unchecked at random for testing), the green dot invariably reappears.

JLChamberlain commented 1 year ago

Can also confirm this is happening for me. All permissions granted and as the others have stated the dot will appear on any non-google domains.

bijij commented 1 year ago

Hi there, This seems to be a new initiative from mozilla for extensions with the activeTab permission who don't require access on all domains.

I've resolved it by disabling the ability to open the "search-by-image" context-menu item in the current tab. A new release (v4.1.0) is coming shortly which should resolve this.