search

bijij / ViewImage

Extension to re-implement the "View Image" and "Search by image" buttons into google images.
MIT License
780 stars 106 forks source link

Stopped working #285

Open nicolaasjan opened 2 months ago

nicolaasjan commented 2 months ago

Describe the bug View Image (v5.1.0) button does not appear any more.

To Reproduce Go to: https://www.google.com/search?hl=en&q=cats&udm=2 and click on a random image.

Expected behavior View Image button should appear.

Screenshot

screenshor_20240615

System Information Firefox 127.0 & Chromium-dev 128.0.6539.0

Additional context Userscript from @ner00 doesn't work either (v3.7.0.14)

[Edit] Works again after switching to the updated script (v3.7.0.15) from @ner00 😀️ (see revision here)

MaskMan191 commented 2 months ago

I'm experiencing the same thing. No "View Image" button appears, just share and save.

foreachthing commented 2 months ago

It's right there: image

View Image (v5.1.0), Brave Browser (1.67.116 Chromium: 126.0.6478.71 (Official Build) (64-bit)) on Windows 11. But it's missing in Firefox...

ner00 commented 2 months ago

I think some people are getting a new class name instead of the one embedded in the code, namely .tvh9oe, which in my case now either uses .EIehLd or .fHE6De.

https://github.com/bijij/ViewImage/blob/200827af5fbcfdcf74971cb4350d2fc92ac7b465/js/content-script.js#L34C11-L34C43

nicolaasjan commented 2 months ago

I think some people are getting a new class name instead of the one embedded in the code, namely .tvh9oe, which in my case now either uses .EIehLd or .fHE6De.

https://github.com/bijij/ViewImage/blob/200827af5fbcfdcf74971cb4350d2fc92ac7b465/js/content-script.js#L34C11-L34C43

I can't find EIehLd or fHE6De in the source code of the page. And I don't know exactly where to look what is used with the inspector...

ner00 commented 2 months ago

I can't find EIehLd or fHE6De in the source code of the page. And I don't know exactly where to look what is used with the inspector...

Try to locate yourself based on the screenshot below (search term was cats)

image

Note that the selected div is the following:

<div jsname="CGzTgf" class="BIB1wf EIehLd fHE6De" data-tbnid="eAP244UcF5wdYM" data-hveid="2" decode-data-ved="1" data-ved="0CAIQmNAHahcKEwjglbqrs96GAxUAAAAAHQAAAAAQIw" data-lhcontainer="1" jscontroller="reJ4Ud" jsmodel="pbt71c" jsaction="rcuQ6b:npT2md" style="display: block;">

class="BIB1wf EIehLd fHE6De" being the point of interest, previously one of those 3 classes (.BIB1wf, .EIehLd, .fHE6De) would be .tvh9oe, yet for me that is no longer the case and why it fails.

foreachthing commented 2 months ago

I just noticed, that the extension "Google Images Restored" was active. Without it, there is no link in Brave either.

ner00 commented 2 months ago

there is no link in Brave either.

This is because Google is constantly doing A/B implementations, where they change something and push that to a group of users and not another. Usually if you are logged in you should have the same issue across browsers, but those A/B tests are pushed based on different variables which I can only guess (cookies, preferences, browser, region, primary language, etc.). Unfortunately this type of thing has been happening pretty often in the past couple years.

In fact, in the past few months this extension implemented some pretty good dynamic code to detect the elements that were more prone to change, but this time Google seems to have made changes to a class name that was not dynamically detected (it hadn't changed in years), hence why it broke like this.

nicolaasjan commented 2 months ago

Thanks! It works again using your updated script. Now the extension needs to be updated as well.

ner00 commented 2 months ago

It works again using your updated script.

Cool. If possible, please edit your opening post where you say it doesn't work (it may be chronologically confusing).

Reonu commented 2 months ago

Will the extension itself be updated to account for this?

bijij commented 2 months ago

Hi All, I've submitted a new version 5.2 which should hopefully resolve this issue.

nicolaasjan commented 2 months ago

Thanks!

MaskMan191 commented 2 months ago

Hi All, I've submitted a new version 5.2 which should hopefully resolve this issue.

Any ETA on when it will be updated for Firefox? Not sure why the topic author closed the issue when the issue is still present.

nicolaasjan commented 2 months ago

Not sure why the topic author closed the issue when the issue is still present.

It is fixed on Chromium. 🙂 I will reopen when for some reason the coming update won't work on Firefox.

bijij commented 2 months ago

Any ETA on when it will be updated for Firefox? Not sure why the topic author closed the issue when the issue is still present.

Still waiting on Mozilla to approve the update unfortunately, hopefully sooner than later.

MaskMan191 commented 1 month ago

Any ETA on when it will be updated for Firefox? Not sure why the topic author closed the issue when the issue is still present.

Still waiting on Mozilla to approve the update unfortunately, hopefully sooner than later.

Did Mozilla just never approve this? It still isn't working.

nicolaasjan commented 1 month ago

For some reason version 5.2.0 stopped working again on Firefox. 🤔 The userscript from @ner00 still works.