search

bijukunjummen / spring-cloud-ping-pong-sample

Sample spring-cloud based app
111 stars 104 forks source link

@EnableDiscoveryClient #1

Closed pjkCochin closed 9 years ago

pjkCochin commented 9 years ago

Hi Biju, I found your blog / dzone articles and this sample code very useful for me to learn and get my feet wet with spring cloud netflix. Thanks! In PingApplictions do we need @EnableDiscoveryClient annotation? I tested without it and seems to work. Just wanted to send a PR your way. Let me know if I am missing something here.

Thanks, Paul John https://twitter.com/pjk_cochin

bijukunjummen commented 9 years ago

Awesome, thanks @pjkCochin. Sorry I totally missed your PR. let me merge it in now.

pjkCochin commented 9 years ago

Thanks Biju. Appreciate it pal. Thanks, Paul

  From: Biju Kunjummen <notifications@github.com>

To: bijukunjummen/spring-cloud-ping-pong-sample spring-cloud-ping-pong-sample@noreply.github.com Cc: Paul John paul00091@yahoo.com Sent: Thursday, September 3, 2015 1:10 AM Subject: Re: [spring-cloud-ping-pong-sample] @EnableDiscoveryClient (#1)

Awesome, thanks @pjkCochin. Sorry I totally missed your PR. let me merge it in now.— Reply to this email directly or view it on GitHub.