search

bikass / kora

Kora icon theme for GNU/Linux os
GNU General Public License v3.0
660 stars 31 forks source link

Dark missed call notification icon in light panel theme #66

Closed Digitalone1 closed 3 years ago

Digitalone1 commented 4 years ago

As the title says.

KDE_connect_missed_call

xzj8b3 commented 4 years ago

Come dice il titolo.

KDE_connect_missed_call

In some people they are not very visible especially in Gnome Shell themes where dark themes are used, but also with white windows!!

It would take a variant to be visible on both!!!!

After the last update also the Rhythmbox icon seems to have disappeared!!!!

Digitalone1 commented 4 years ago

@bikass maybe I found the reason.

call-missed-symbolic icon is missing in korla-light.

A search for call in korla-light: Screenshot_20200506_153300

Same search in korla: Screenshot_20200506_153433

I think it relies on Breeze and that's why it's shown white. See also that call-start-symbolic icons have different styles.

xzj8b3 commented 4 years ago

As the title says.

KDE_connect_missed_call

Yes, but it would take a segment mode on dark themes but also with white parts.

It is the best theme without a doubt, personally I would also change window buttons (close, enlarge, minimize) with something more beautiful ... it's the best, perfect it that's great!!

bikass commented 4 years ago

If icons in "symbolic' folder I can change them and add (I recently remade all these icons). "actions/scalable" and 'panel' icons are from Papirus theme. They have code that I don't know any automatic way to make them. Some icons changes from dark to light and some don't. I wonder if it would help if in status/symbolic We made dark icons (now they are symelinked to korla/status.symbolic)? Does someone knows some way or script to change color to all icons?

Digitalone1 commented 4 years ago

You can change color with atom text editor. It should be easy since svg are text files.

Open a project on korla folder, then search for a color and replace it with another one.

Which color you have to change in particular?

bikass commented 4 years ago

@xzj8b3 And regarding minimize, close buttons I can change them they are in actions symbolic. But not realy sure into what design. It's just dash, square and x

bikass commented 4 years ago

WE could try changing korla-light/status/symbolic. But it is symelinked so links needs to be redone too. Dark icons from Papirus has this color #444444

Digitalone1 commented 4 years ago

So you have to change #444444 color into another color? Only inside korla-light/status/symbolic?

Edit: no, you have to change a color to #444444, right?

xzj8b3 commented 4 years ago

@xzj8b3 And regarding minimize, close buttons I can change them they are in actions symbolic. [ E per quanto riguarda i pulsanti minimizza, chiudi posso cambiarli, sono in azioni simboliche.] But not realy sure into what design. [ Ma non sono sicuro di quale design.] It's just dash, square and x [ È solo trattino, quadrato e x]

Cuter, too cute theme for such simple buttons!!!

xzj8b3 commented 4 years ago

You can change color with atom text editor. It should be easy since svg are text files.

Open a project on korla folder, then search for a color and replace it with another one.

Which color you have to change in particular?

That's not the point.

Some themes use both black and white

and no more icons are shown in the button or right button menu.

The Top would be a blue variant where you can see how it was done for the one with gray folders!!

Otherwise we can release please enter a small text file with all possible variables can be done via gedit or terminal please!!!

Digitalone1 commented 4 years ago

Otherwise we can release please enter a small text file with all possible variables can be done via gedit or terminal please!!!

Sorry, I don't get what you mean.

xzj8b3 commented 4 years ago

Otherwise we can release please enter a small text file with all possible variables can be done via gedit or terminal please!!!

Sorry, I don't get what you mean.

Selezione_004

Selezione_003 What I meant is a more visible version even in those cases because if I change, I don't see any more buttons....

Instead even with Gnome Shell are born excellent themes that with your icons are fantastic is creating a variant of the buttons that is visible correctly in both cases would be exceptional ... with buttons for the prettiest windows ....

Now I use only your icons ... if you solve these small details would deserve a theme repository ... no more beautiful you were great!!

xzj8b3 commented 4 years ago

Otherwise we can release please enter a small text file with all possible variables can be done via gedit or terminal please!!!

Sorry, I don't get what you mean.

Selezione_004

Selezione_003 What I meant is a more visible version even in those cases because if I change, I don't see any more buttons....

Instead even with Gnome Shell are born excellent themes that with your icons are fantastic is creating a variant of the buttons that is visible correctly in both cases would be exceptional ... with buttons for the prettiest windows ....

Now I use only your icons ... if you solve these small details would deserve a theme repository ... no more beautiful you were great!!

WE could try changing korla-light/status/symbolic. But it is symelinked so links needs to be redone too. Dark icons from Papirus has this color #444444

explain better or put details in a readme file in the next version, I put an example in a comment below ... if I change on white I don't see those buttons anymore ... While on Bleachbit you can see little ... how can I resole??

I used Korla-light-panel

Digitalone1 commented 4 years ago

This should be fixed with the last pull request.

Digitalone1 commented 4 years ago

@xzj8b3 Sorry I deleted a messege of yours by mistake.

Anyway, that is my reply:

It is not possible to create a variant Korla-dark-light-panel ??

Selezione_004

If you use korla-light-panel, you have to use a light theme. Can't you change your desktop theme? Or if you're using a desktop dark theme, switch to korla.