search

bikass / kora

Kora icon theme for GNU/Linux os
GNU General Public License v3.0
660 stars 31 forks source link

Why name change. #99

Closed algent-al closed 3 years ago

algent-al commented 3 years ago

I am curious about why did you change the name?

bikass commented 3 years ago

Did spelling mistake when created theme. I wanted to correct name for a long time, just didn't knew how. Apologies for inconvenience.

algent-al commented 3 years ago

Name korla was fine in my opinion. What conserns me is if it will break existing installations for at least solus users when transiting from korla to kora.

bikass commented 3 years ago

Maybe you can fork it with korla name. Anyway there is not going to be much changes, just some app icons. I already gave up making it original theme.

Digitalone1 commented 3 years ago

Name korla was fine in my opinion. What conserns me is if it will break existing installations for at least solus users when transiting from korla to kora.

The icon theme should be changed from the system settings and the installation process needs some modification since the path is changed.

But this should be done only when the new release will come out.

Digitalone1 commented 3 years ago

@bikass please, before to release the new version, mention me here so I can make a test on Arch Linux and see if everything is okay, then the release can be made safely.

bikass commented 3 years ago

Ok, I'll drop a line here. There is one more thing :) I'm working on 'panel' icons. And because I don't know how batch resize icons, I left just one size - folder panel/16

D3SOX commented 3 years ago

Can you make a new release/tag with the new name? I will create a new AUR package with the name of kora-icon-theme and merge it with my old package.

Digitalone1 commented 3 years ago

@D3SOX The name has been already changed. The new release will come out when it's ready.

D3SOX commented 3 years ago

I know but the folders in the current release are still named korla

bikass commented 3 years ago

Does anybody know how this icon is called, cant find it? app_icon

algent-al commented 3 years ago

Does anybody know how this icon is called, cant find it? app_icon

There is already an issue about this. https://github.com/bikass/kora/issues/70

But still you have to verify if it is that icon.

bikass commented 3 years ago

Thank you! So, that was preferences-desktop-apps-symbolic.svg

D3SOX commented 3 years ago

I created an AUR package with the new name https://aur.archlinux.org/packages/kora-icon-theme-git/

bikass commented 3 years ago

@D3SOX Thank you! Does anyone uses Prof-Gnome-Dark-3.6 shell theme? In case you are, and don't like those three bubbles to close windows, I made small changes. And those icons kind-of animates. Screenshot from 2020-12-29 17-38-33

algent-al commented 3 years ago

Thank you! So, that was preferences-desktop-apps-symbolic.svg

@bikass Yeah, I did a search on my Solus system, only Adwaita Icon Theme has that file. Package adwaita-icon-theme has file /usr/share/icons/Adwaita/scalable/apps/preferences-desktop-apps-symbolic.svg

bikass commented 3 years ago

@Digitalone1 Ok, so I finished 'panel' icons, you can test theme. I will be releasing someday in the beginning of January.

Digitalone1 commented 3 years ago

I'm checking in the next hours and let you know.

Digitalone1 commented 3 years ago

I made some adjustments. Tested on my system, it's working without issue, at least the korla light which I use daily.

I'll test also the others, but I don't know where to test status and places icons. Most of the applications I use don't show them.

bikass commented 3 years ago

OK, cool should be fine.

Digitalone1 commented 3 years ago

But please next time when you change an icon in kora, change also the light version in kora-light, many of them was missing. I had to copy korla places in kora-light and replace #dfdfdf color with #444444. Thank God atom editor does this in 2 minutes. :)

bikass commented 3 years ago

Ok, thank you :)

algent-al commented 3 years ago

Ok, I'll drop a line here. There is one more thing :) I'm working on 'panel' icons. And because I don't know how batch resize icons, I left just one size - folder panel/16

This is bad for Budgie Desktop. There is already an issue about this.

algent-al commented 3 years ago

It wasn't that easy but I think i should keep the name korla for Solus users.

EDIT: Our package.yml file.

algent-al commented 3 years ago

The theme is working without any issue on Solus, by keeping old name.

bikass commented 3 years ago

Hi, ok cool. Thanks!

algent-al commented 3 years ago

Closing this issue, since I don't have any issue on Solus.

murlakatamenka commented 3 years ago

Did spelling mistake when created theme. I wanted to correct name for a long time, just didn't knew how. Apologies for inconvenience.

Oh man, I like korla name so much. It has a call letter / sound l that sounds so nicely here.

Came here cause there is no AUR package anymore, it got renamed too.

Thank you very much for the icons ❤️