Reference implementation. Closes #8

bike-barn / red-green-refactor

A very simple calculator designed to teach software testing.

ISC License

4 stars 2 forks source link

Reference implementation. Closes #8 #13

Closed reillysiemens closed 8 years ago

reillysiemens commented 8 years ago

Description

This set of changes includes improvements to error handling by raising the CalcError exception with useful error information. It also makes the test_calculator.py (formerly intepreter.py) tests pass and wires the calculator up to the console script entry point given in setup.py. This allows the calculator to be invoked as calc after running pip install -e ..

Check List

[x] All test passed
[x] Any new functionality or fixes you added is covered by new tests

rawrgulmuffins commented 8 years ago

All tests don't pass? Intentional?

rawrgulmuffins commented 8 years ago

Add a couple of small comments. Potentially add me as a push member on your fork so I can do formatting and code tidying when you're not available?

reillysiemens commented 8 years ago

Yes, all tests don't pass. The token tests are broken.

reillysiemens commented 8 years ago

I'm going to make this a WIP/Don't merge PR instead. I'll change the title again when I feel it's ready.

reillysiemens commented 8 years ago

@rawrgulmuffins: What small comments did you have in mind?

rawrgulmuffins commented 8 years ago

Reading PR now.

rawrgulmuffins commented 8 years ago

This PR was targeted to Red-Green-Refactor:master. Needs to be targeted to red-green-refactor:reference_implementation rather thenmaster.

My mistake for merging it.

Paging @reillysiemens