Closed rawrgulmuffins closed 8 years ago
Possibly include a Rabbit Hole about default function arguments as not all languages have those.
Rabbit Hole
Move constructor documentation into __init__ methods.
__init__
_next_token's docstring is broken and does not help students. Circular definitions are bad.
_next_token
_next_token needs to be explicit that it can only return a token (Our return currently says returns None) or raise a CalcError.
None
CalcError
Add a note about don't over think things. Just do character matching to generate tokens.
Leave a note about starting in the parse method and that we expect the call graph to go from parse -> consume -> next_token.
parse
consume
next_token
We need to walk people through running the tests as the first thing. Then selecting a test you want to pass.
next_token needs to be explicit that it only checks a token at a time.
Closed with #23.
rawrgulmuffins
commented
8 years ago rawrgulmuffins
commented
8 years ago
Possibly include a
Rabbit Holeabout default function arguments as not all languages have those.Move constructor documentation into
__init__methods._next_token's docstring is broken and does not help students. Circular definitions are bad._next_tokenneeds to be explicit that it can only return a token (Our return currently says returnsNone) or raise aCalcError.Add a note about don't over think things. Just do character matching to generate tokens.
Leave a note about starting in the parse method and that we expect the call graph to go from
parse->consume->next_token.We need to walk people through running the tests as the first thing. Then selecting a test you want to pass.
next_tokenneeds to be explicit that it only checks a token at a time.