search

bikebrigade / dispatch

Bike Brigade's dispatching software! 🚴
https://bikebrigade.ca
Apache License 2.0
75 stars 9 forks source link

Rider Login via itinerary #137

Open mveytsman opened 2 years ago

mveytsman commented 2 years ago

Currently rider delivery details are per delivery - so we just have a link with a unique token.

After we add #135 and #136 we'll need a way for Riders to log into the app after we send them an itinerary link.

Note: Dispatchers see these links and click on them, so making them auto log you in might break things.

We can either phase out the links as is, and instead send you to a link that forces login. We might also phase out the "show in app" button we show to dispatchers when messaging.

teesloane commented 1 year ago

After we add https://github.com/bikebrigade/dispatch/issues/135 and https://github.com/bikebrigade/dispatch/issues/136 we'll need a way for riders to log into the app after we send them an itinerary link.

Is an "itinerary link" the same as the link I get the night before from a dispatcher with my delivery details? (I'm going to call that the Rider Delivery Detail Page or RDDP, since I'm not sure what else to call it).

If that's what the itinerary link indeed is, do you want to add a link that takes the rider to log into the dispatch app from the RDDP? If so, why? So that, I can see other deliveries that might be coming later that day or week?

mveytsman commented 1 year ago

I think the idea is to have a link that automatically logs you in via token, and yes so you can see your full day's deliveiries.

Does that make sense?

teesloane commented 12 months ago

I think the idea is to have a link that automatically logs you in via token, and yes so you can see your full day's deliveiries.

Does that make sense?

Makes sense.

The original issue says:

Note: Dispatchers see these links and click on them, so making them auto log you in might break things.

Which links are these being referred to? the ones that are sent to riders with the unique token for their delivery? Ie, we can't use that link to trigger a log in because there's a chance that a dispatcher would also click on that and use up a login code?

mveytsman commented 12 months ago

Ah right. That's a good point that past Max had 😅

I think we need to write out the login flow, or at least the first iteration. Want to pair on this?

On Tue, Nov 21, 2023 at 7:12 AM tees @.***> wrote:

I think the idea is to have a link that automatically logs you in via token, and yes so you can see your full day's deliveiries.

Does that make sense?

Makes sense.

The original issue says:

Note: Dispatchers see these links and click on them, so making them auto log you in might break things.

Which links are these being referred to? the ones that are sent to riders with the unique token for their delivery? Ie, we can't use that link to trigger a log in because there's a chance that a dispatcher would also click on that and use up a login code?

— Reply to this email directly, view it on GitHub https://github.com/bikebrigade/dispatch/issues/137#issuecomment-1820805074, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIPICW3IJLEPSGC64TXK3YFSLEBAVCNFSM5223BELKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBSGA4DANJQG42A . You are receiving this because you authored the thread.Message ID: @.***>

mveytsman commented 12 months ago

For starters let's begin by adding a link to the delivery token page that will take a rider to the "/itinerary" link — for now a single button somewhere on the page is sufficient. If the rider is not logged in, they will login and then it should forward them to /itinerary.

teesloane commented 11 months ago

I think we can technically close this due to this PR. We don't log in via the itinerary, but we are able to go to the itinerary from a delivery page.