bikebrigade / dispatch

Bike Brigade's dispatching software! 🚴
https://bikebrigade.ca
Apache License 2.0
74 stars 9 forks source link

Displaying notes on signups - possible privacy concerns #340

Closed chadmohr closed 4 months ago

chadmohr commented 5 months ago

There are cases where names, contact info and even other personal info is put in notes. Basically, there could be anything in the notes. And these notes are displayed on desktops in the rider signups.

Untitled

mveytsman commented 5 months ago

This is a good catch!

Based on the convo in slack we'll hide these before signup. Cecily also suggested splitting up rider notes and signup notes in the future

@chadmohr I went ahead and edited the image to block the phone number, do you mind doing that in the future if you're uploading screenshots with private info?

chadmohr commented 5 months ago

Yes, for sure. This occurred to me after I posted.

chadmohr commented 5 months ago

Also, somewhere in here I am 99% sure I also suggested a signup notes box in addition to the delivery notes

sereprz commented 5 months ago

We're going to hide the column for now and revisit how to handle notes later on e.g. notes on signup VS notes on delivery

see discussion in #349

chadmohr commented 5 months ago

349 is closed.

I don’t really understand the hesitation with the delivery and signup notes. Seems to me adding the latter solves a lot of problems.

chadmohr commented 4 months ago

@teesloane the notes bstill show on mobile image