search

bikebrigade / dispatch

Bike Brigade's dispatching software! 🚴
https://bikebrigade.ca
Apache License 2.0
72 stars 9 forks source link

Fix: swap pickup notes for rider_notes on campaign singup. #349

Closed teesloane closed 2 months ago

teesloane commented 2 months ago

Fixes #340

mveytsman commented 2 months ago

Just to be clear we haven't added any form to fill them in yet right?

teesloane commented 2 months ago

Just to be clear we haven't added any form to fill them in yet right?

I did actually add it to the task form. I should have added a screenshot:

CleanShot 2024-04-28 at 16 02 45@2x

mveytsman commented 2 months ago

Oh sorry, I missed the html bits.

To be honest, I'm not 100% sure on this: I think the issue that this has PII and should be hidden from the public page should be addressed.

I think before adding a separate field we should iterate on clear instructions and train dispatchers e.g. I notice there's a todo to rename the field from rider notes to delivery instructions.

What if we make a PR to hide it and then get some feedbakc on slack on copy for adding a second field?

teesloane commented 2 months ago

Sure, I'll make a PR to hide the delivery notes for now and then we can circle back to this when necessary :)