bikebrigade / dispatch

Bike Brigade's dispatching software! 🚴
https://bikebrigade.ca
Apache License 2.0
72 stars 8 forks source link

fix: remove date filter when fetching campaign_ids #387

Open teesloane opened 3 weeks ago

teesloane commented 3 weeks ago

fixes #369

Here is a video demonstrating the bug on a sunday, as well as the fix:

https://github.com/bikebrigade/dispatch/assets/12987958/28951629-c34f-4149-b913-9aa3e59c1f49

Describe your changes

@mveytsman any ideas on how I could write a test for this that simulates that it's a sunday locally and the campaigns in question are on a monday (without changing the system under test?)

Checklist before requesting a review

teesloane commented 3 weeks ago

Also, I added some needed padding on desktop.

image

(1 is from before, 2 is after)

teesloane commented 2 weeks ago

Will test this again just to be sure on sunday :)

edit: oh wait... i added a test for this...

but maybe I will still test on sunday.

you know?

Just to be sure?

mveytsman commented 1 week ago

Did it work?

teesloane commented 1 week ago

Did it work?

I forgot to test yesterday 🙃