Closed osnoser1 closed 4 years ago
@osnoser1 can you please describe the PR? You can use the Angular PR template to do that.
I have no experience on this field and would be nice to have an explanation instead of reading code to understand what was wrong
Done @dianjuar 👍🏼
@osnoser1 Your PR is just awesome!
I will run Unit Test and Sonar Analysis (I now, I now, the CI should be doing this)and tell you how it went.
If nothing happens I will integrate your PR.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In SSR runtime occurs two exceptions: window and document is not defined.
Issue Number: #18
What is the new behavior?
All exceptions are gone in ssr.
Does this PR introduce a breaking change?
Other information
This PR has two commits:
window
exception, not create the IntersectionObserver instance in ssr because it isn't work, and inject thedocument
by angular because in ssr that it is created by domino library that angular uses since version 6 .Closes #18